2013-08-12 13:38:25

by Alexander Popov

[permalink] [raw]
Subject: Re: [PATCH RFC v2 1/5] dma: mpc512x: re-order mpc8308 specific instructions

Hello everyone!

2013/7/14 Gerhard Sittig <[email protected]>:
> @@ -50,9 +50,23 @@
> #define MPC_DMA_DESCRIPTORS 64
>
> /* Macro definitions */
> -#define MPC_DMA_CHANNELS 64
> #define MPC_DMA_TCD_OFFSET 0x1000
>
> +/*
> + * the maximum channel count, and specific channels which need
> + * special processing, for individual hardware variants
> + *
> + * and the maximum channel count over all supported controllers,
> + * used for data structure sizes
> + */
> +enum mpc8308_dmachan_id_t {
> + MPC8308_DMACHAN_MAX = 16,
> +};
> +enum mpc512x_dmachan_id_t {
> + MPC512x_DMACHAN_MAX = 64,
> +};
> +#define MPC_DMA_CHANNELS 64
> +

I offer to use #define instead of enum here
since individual channels don't require special handling.

Best regards,
Alexander.