2014-07-09 08:48:54

by Chen Gang

[permalink] [raw]
Subject: [PATCH] arch: score: Export necessary symbols in related files

'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by
outside modules, so need export them in the related files.

The related error (with allmodconfig under score):

MODPOST 1365 modules
ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!


Signed-off-by: Chen Gang <[email protected]>
---
arch/score/lib/checksum_copy.c | 1 +
arch/score/mm/cache.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/arch/score/lib/checksum_copy.c b/arch/score/lib/checksum_copy.c
index 04565dd..9b770b3 100644
--- a/arch/score/lib/checksum_copy.c
+++ b/arch/score/lib/checksum_copy.c
@@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,

return csum_partial(dst, len, sum);
}
+EXPORT_SYMBOL(csum_partial_copy_from_user);
diff --git a/arch/score/mm/cache.c b/arch/score/mm/cache.c
index f85ec1a..be91041 100644
--- a/arch/score/mm/cache.c
+++ b/arch/score/mm/cache.c
@@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
addr = (unsigned long) page_address(page);
flush_data_cache_page(addr);
}
+EXPORT_SYMBOL(flush_dcache_page);

/* called by update_mmu_cache. */
void __update_cache(struct vm_area_struct *vma, unsigned long address,
--
1.9.2.459.g68773ac


2014-07-17 02:22:33

by Lennox Wu

[permalink] [raw]
Subject: Re: [PATCH] arch: score: Export necessary symbols in related files

Acked-by: Lennox Wu<[email protected]>

2014-07-09 16:48 GMT+08:00 Chen Gang <[email protected]>:
> 'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by
> outside modules, so need export them in the related files.
>
> The related error (with allmodconfig under score):
>
> MODPOST 1365 modules
> ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
> ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!
>
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/score/lib/checksum_copy.c | 1 +
> arch/score/mm/cache.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/score/lib/checksum_copy.c b/arch/score/lib/checksum_copy.c
> index 04565dd..9b770b3 100644
> --- a/arch/score/lib/checksum_copy.c
> +++ b/arch/score/lib/checksum_copy.c
> @@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
>
> return csum_partial(dst, len, sum);
> }
> +EXPORT_SYMBOL(csum_partial_copy_from_user);
> diff --git a/arch/score/mm/cache.c b/arch/score/mm/cache.c
> index f85ec1a..be91041 100644
> --- a/arch/score/mm/cache.c
> +++ b/arch/score/mm/cache.c
> @@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
> addr = (unsigned long) page_address(page);
> flush_data_cache_page(addr);
> }
> +EXPORT_SYMBOL(flush_dcache_page);
>
> /* called by update_mmu_cache. */
> void __update_cache(struct vm_area_struct *vma, unsigned long address,
> --
> 1.9.2.459.g68773ac

2014-07-17 09:01:59

by Chen Gang

[permalink] [raw]
Subject: Re: [PATCH] arch: score: Export necessary symbols in related files

On 07/17/2014 10:22 AM, Lennox Wu wrote:
> Acked-by: Lennox Wu<[email protected]>
>

OK, thank you for your work.


> 2014-07-09 16:48 GMT+08:00 Chen Gang <[email protected]>:
>> 'csum_partial_copy_from_user' and 'flush_dcache_page' are also needed by
>> outside modules, so need export them in the related files.
>>
>> The related error (with allmodconfig under score):
>>
>> MODPOST 1365 modules
>> ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rxrpc.ko] undefined!
>> ERROR: "flush_dcache_page" [net/sunrpc/sunrpc.ko] undefined!
>>
>>
>> Signed-off-by: Chen Gang <[email protected]>
>> ---
>> arch/score/lib/checksum_copy.c | 1 +
>> arch/score/mm/cache.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/score/lib/checksum_copy.c b/arch/score/lib/checksum_copy.c
>> index 04565dd..9b770b3 100644
>> --- a/arch/score/lib/checksum_copy.c
>> +++ b/arch/score/lib/checksum_copy.c
>> @@ -50,3 +50,4 @@ unsigned int csum_partial_copy_from_user(const char *src, char *dst,
>>
>> return csum_partial(dst, len, sum);
>> }
>> +EXPORT_SYMBOL(csum_partial_copy_from_user);
>> diff --git a/arch/score/mm/cache.c b/arch/score/mm/cache.c
>> index f85ec1a..be91041 100644
>> --- a/arch/score/mm/cache.c
>> +++ b/arch/score/mm/cache.c
>> @@ -72,6 +72,7 @@ void flush_dcache_page(struct page *page)
>> addr = (unsigned long) page_address(page);
>> flush_data_cache_page(addr);
>> }
>> +EXPORT_SYMBOL(flush_dcache_page);
>>
>> /* called by update_mmu_cache. */
>> void __update_cache(struct vm_area_struct *vma, unsigned long address,
>> --
>> 1.9.2.459.g68773ac

--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed