2024-04-24 19:20:35

by Konstantin Pugin

[permalink] [raw]
Subject: [PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART

From: Konstantin Pugin <[email protected]>

EXAR XR20M1172 UART is mostly register-compatible with NXP SPI UARTs.
It will be handled by same driver, so, it makes sense to add DT
definition for these block into driver's documentation.

Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Vladimir Zapolskiy <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Signed-off-by: Konstantin Pugin <[email protected]>
---
Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
index 5dec15b7e7c3..c4bedf23368b 100644
--- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
+++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
@@ -12,6 +12,7 @@ maintainers:
properties:
compatible:
enum:
+ - exar,xr20m1172
- nxp,sc16is740
- nxp,sc16is741
- nxp,sc16is750
--
2.44.0



2024-04-24 19:34:50

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART

On Wed, Apr 24, 2024 at 10:19 PM Konstantin Pugin <[email protected]> wrote:
>
> From: Konstantin Pugin <[email protected]>
>
> EXAR XR20M1172 UART is mostly register-compatible with NXP SPI UARTs.
> It will be handled by same driver, so, it makes sense to add DT
> definition for these block into driver's documentation.

blocks

..

> Reviewed-by: Andy Shevchenko <[email protected]>

Hmm... Did I? IIRC I only reviewed patches 1 and 3. Am I mistaken?

--
With Best Regards,
Andy Shevchenko

2024-04-25 07:23:40

by Konstantin P.

[permalink] [raw]
Subject: Re: [PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART

On Wed, Apr 24, 2024 at 10:34 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Wed, Apr 24, 2024 at 10:19 PM Konstantin Pugin <[email protected]> wrote:
> >
> > From: Konstantin Pugin <[email protected]>
> >
> > EXAR XR20M1172 UART is mostly register-compatible with NXP SPI UARTs.
> > It will be handled by same driver, so, it makes sense to add DT
> > definition for these block into driver's documentation.
>
> blocks
>
> ...
>
> > Reviewed-by: Andy Shevchenko <[email protected]>
>
> Hmm... Did I? IIRC I only reviewed patches 1 and 3. Am I mistaken?

I think it is my mistake, not yours. If you want, I can do a new
version without a tag.

> --
> With Best Regards,
> Andy Shevchenko

2024-04-25 09:12:21

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v8 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART

On Thu, Apr 25, 2024 at 10:25:41AM +0300, Konstantin P. wrote:
> On Wed, Apr 24, 2024 at 10:34 PM Andy Shevchenko
> <[email protected]> wrote:
> > On Wed, Apr 24, 2024 at 10:19 PM Konstantin Pugin <[email protected]> wrote:
> > >
> > > From: Konstantin Pugin <[email protected]>
> > >
> > > EXAR XR20M1172 UART is mostly register-compatible with NXP SPI UARTs.
> > > It will be handled by same driver, so, it makes sense to add DT
> > > definition for these block into driver's documentation.
> >
> > blocks

..

> > > Reviewed-by: Andy Shevchenko <[email protected]>
> >
> > Hmm... Did I? IIRC I only reviewed patches 1 and 3. Am I mistaken?
>
> I think it is my mistake, not yours. If you want, I can do a new
> version without a tag.

Yes, but give a chance to others to have a look at the code and the rest.

--
With Best Regards,
Andy Shevchenko