2014-06-14 22:24:22

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 1/1] drivers/gpu/drm/msm/msm_iommu.c: use PAGE_ALIGNED instead of IS_ALIGNED(PAGE_SIZE

use mm.h definition

Cc: David Airlie <[email protected]>
Cc: Rob Clark <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/gpu/drm/msm/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c
index 92b7459..198ed84 100644
--- a/drivers/gpu/drm/msm/msm_iommu.c
+++ b/drivers/gpu/drm/msm/msm_iommu.c
@@ -110,7 +110,7 @@ static int msm_iommu_unmap(struct msm_mmu *mmu, uint32_t iova,

VERB("unmap[%d]: %08x(%x)", i, iova, bytes);

- BUG_ON(!IS_ALIGNED(bytes, PAGE_SIZE));
+ BUG_ON(!PAGE_ALIGNED(bytes));

da += bytes;
}
--
1.8.4.5


2014-06-17 15:13:22

by Rob Clark

[permalink] [raw]
Subject: Re: [PATCH 1/1] drivers/gpu/drm/msm/msm_iommu.c: use PAGE_ALIGNED instead of IS_ALIGNED(PAGE_SIZE

On Sat, Jun 14, 2014 at 6:24 PM, Fabian Frederick <[email protected]> wrote:
> use mm.h definition
>
> Cc: David Airlie <[email protected]>
> Cc: Rob Clark <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>

Thanks, I've got this queued up

BR,
-R

> ---
> drivers/gpu/drm/msm/msm_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c
> index 92b7459..198ed84 100644
> --- a/drivers/gpu/drm/msm/msm_iommu.c
> +++ b/drivers/gpu/drm/msm/msm_iommu.c
> @@ -110,7 +110,7 @@ static int msm_iommu_unmap(struct msm_mmu *mmu, uint32_t iova,
>
> VERB("unmap[%d]: %08x(%x)", i, iova, bytes);
>
> - BUG_ON(!IS_ALIGNED(bytes, PAGE_SIZE));
> + BUG_ON(!PAGE_ALIGNED(bytes));
>
> da += bytes;
> }
> --
> 1.8.4.5
>