2022-07-31 20:02:52

by Christophe JAILLET

Subject: [PATCH] HID: wacom: Simplify comments

Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
boilerplate/reference with SPDX - rule 152").
An empty comment block can be removed.

While at it remove, also remove what is supposed to be the path/filename of
the file.
This is really low value... and wrong since commit 471d17148c8b
("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/hid/wacom_sys.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 194a2e327591..21612fdae9c3 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1,13 +1,8 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
- * drivers/input/tablet/wacom_sys.c
- *
* USB Wacom tablet support - system specific code
*/

-/*
- */
-
#include "wacom_wac.h"
#include "wacom.h"
#include <linux/input/mt.h>
--
2.34.1

2022-08-02 16:44:00

by Jason Gerecke

Subject: Re: [PATCH] HID: wacom: Simplify comments

On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
<[email protected]> wrote:
>
> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
> boilerplate/reference with SPDX - rule 152").
> An empty comment block can be removed.
>
> While at it remove, also remove what is supposed to be the path/filename of
> the file.
> This is really low value... and wrong since commit 471d17148c8b
> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/hid/wacom_sys.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 194a2e327591..21612fdae9c3 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1,13 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * drivers/input/tablet/wacom_sys.c
> - *
> * USB Wacom tablet support - system specific code
> */
>
> -/*
> - */
> -
> #include "wacom_wac.h"
> #include "wacom.h"
> #include <linux/input/mt.h>
> --
> 2.34.1
>

LGTM.
Reviewed-by: Jason Gerecke <[email protected]>

2022-08-02 18:48:30

by Ping Cheng

Subject: Re: [PATCH] HID: wacom: Simplify comments

Hi Christophe,

Thank you for cleaning up the driver code.

On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
<[email protected]> wrote:
>
> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
> boilerplate/reference with SPDX - rule 152").
> An empty comment block can be removed.

While you are here, can you update your patch to include the removal
of the empty comment blocks and paths in the other three files:
wacom.h, wacom_wac.h, and wacom_wac.c?

Thanks,
Ping

> While at it remove, also remove what is supposed to be the path/filename of
> the file.
> This is really low value... and wrong since commit 471d17148c8b
> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/hid/wacom_sys.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 194a2e327591..21612fdae9c3 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1,13 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * drivers/input/tablet/wacom_sys.c
> - *
> * USB Wacom tablet support - system specific code
> */
>
> -/*
> - */
> -
> #include "wacom_wac.h"
> #include "wacom.h"
> #include <linux/input/mt.h>
> --
> 2.34.1
>

2022-08-02 18:59:47

by Christophe JAILLET

Subject: Re: [PATCH] HID: wacom: Simplify comments

Le 02/08/2022 à 20:41, Ping Cheng a écrit :
> Hi Christophe,
>
> Thank you for cleaning up the driver code.
>
> On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
> <[email protected]> wrote:
>>
>> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
>> boilerplate/reference with SPDX - rule 152").
>> An empty comment block can be removed.
>
> While you are here, can you update your patch to include the removal
> of the empty comment blocks and paths in the other three files:
> wacom.h, wacom_wac.h, and wacom_wac.c?

I'll send a v2.
Thanks for pointing it out.

CJ


>
> Thanks,
> Ping
>
>> While at it remove, also remove what is supposed to be the path/filename of
>> the file.
>> This is really low value... and wrong since commit 471d17148c8b
>> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>>
>> Signed-off-by: Christophe JAILLET <[email protected]>
>> ---
>> drivers/hid/wacom_sys.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
>> index 194a2e327591..21612fdae9c3 100644
>> --- a/drivers/hid/wacom_sys.c
>> +++ b/drivers/hid/wacom_sys.c
>> @@ -1,13 +1,8 @@
>> // SPDX-License-Identifier: GPL-2.0-or-later
>> /*
>> - * drivers/input/tablet/wacom_sys.c
>> - *
>> * USB Wacom tablet support - system specific code
>> */
>>
>> -/*
>> - */
>> -
>> #include "wacom_wac.h"
>> #include "wacom.h"
>> #include <linux/input/mt.h>
>> --
>> 2.34.1
>>
>