2023-10-30 08:55:48

by Etienne CARRIERE - foss

Subject: [PATCH] optee: add missing description of RPC argument reference

Adds missing inline description comment for RPC optional arguments
reference.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/lkml/[email protected]/
Signed-off-by: Etienne Carriere <[email protected]>
---
drivers/tee/optee/smc_abi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c
index d5b28fd35d66..67bfa25d6302 100644
--- a/drivers/tee/optee/smc_abi.c
+++ b/drivers/tee/optee/smc_abi.c
@@ -806,6 +806,7 @@ static void handle_rpc_func_cmd(struct tee_context *ctx, struct optee *optee,
/**
* optee_handle_rpc() - handle RPC from secure world
* @ctx: context doing the RPC
+ * @rpc_arg: pointer to RPC arguments if any, or NULL if none
* @param: value of registers for the RPC
* @call_ctx: call context. Preserved during one OP-TEE invocation
*
--
2.25.1

2023-10-30 09:06:43

by Sumit Garg

Subject: Re: [PATCH] optee: add missing description of RPC argument reference

On Mon, 30 Oct 2023 at 14:25, Etienne Carriere
<[email protected]> wrote:
>
> Adds missing inline description comment for RPC optional arguments
> reference.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/lkml/[email protected]/
> Signed-off-by: Etienne Carriere <[email protected]>
> ---
> drivers/tee/optee/smc_abi.c | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Sumit Garg <[email protected]>

-Sumit

> diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c
> index d5b28fd35d66..67bfa25d6302 100644
> --- a/drivers/tee/optee/smc_abi.c
> +++ b/drivers/tee/optee/smc_abi.c
> @@ -806,6 +806,7 @@ static void handle_rpc_func_cmd(struct tee_context *ctx, struct optee *optee,
> /**
> * optee_handle_rpc() - handle RPC from secure world
> * @ctx: context doing the RPC
> + * @rpc_arg: pointer to RPC arguments if any, or NULL if none
> * @param: value of registers for the RPC
> * @call_ctx: call context. Preserved during one OP-TEE invocation
> *
> --
> 2.25.1
>