2023-06-15 16:49:32

by Andy Shevchenko

Subject: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion

The of_gpio.h is not and shouldn't be used in the drivers. Remove it.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/mtd/nand/raw/nand_base.c | 1 -
drivers/mtd/nand/raw/xway_nand.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index a6af521832aa..132e3bee8f5a 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -42,7 +42,6 @@
#include <linux/io.h>
#include <linux/mtd/partitions.h>
#include <linux/of.h>
-#include <linux/of_gpio.h>
#include <linux/gpio/consumer.h>

#include "internals.h"
diff --git a/drivers/mtd/nand/raw/xway_nand.c b/drivers/mtd/nand/raw/xway_nand.c
index 6b1e2a2bba15..5a19b6b314b4 100644
--- a/drivers/mtd/nand/raw/xway_nand.c
+++ b/drivers/mtd/nand/raw/xway_nand.c
@@ -6,7 +6,6 @@
*/

#include <linux/mtd/rawnand.h>
-#include <linux/of_gpio.h>
#include <linux/of_platform.h>

#include <lantiq_soc.h>
--
2.40.0.1.gaa8946217a0b

2023-06-15 22:22:47

by Martin Blumenstingl

Subject: Re: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion

On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
<[email protected]> wrote:
>
> The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
Acked-by: Martin Blumenstingl <[email protected]>

2023-07-10 10:17:23

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion

On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:
> On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> <[email protected]> wrote:
> >
> > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
> Acked-by: Martin Blumenstingl <[email protected]>

Thank you!

Can it be applied now?

--
With Best Regards,
Andy Shevchenko

2023-10-06 15:14:40

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion

+Cc: GPIO maintainers

On Mon, Jul 10, 2023 at 01:00:51PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:
> > On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> > <[email protected]> wrote:
> > >
> > > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> > >
> > > Signed-off-by: Andy Shevchenko <[email protected]>
> > Acked-by: Martin Blumenstingl <[email protected]>
>
> Thank you!
>
> Can it be applied now?

So, this is still not applied, does it mean we need to go via GPIO tree
with it?

--
With Best Regards,
Andy Shevchenko

2023-10-06 15:41:56

by Miquel Raynal

Subject: Re: [PATCH v1 1/1] mtd: rawnand: Remove unused of_gpio.h inclusion

Hi Andy,

[email protected] wrote on Fri, 6 Oct 2023 18:14:24
+0300:

> +Cc: GPIO maintainers
>
> On Mon, Jul 10, 2023 at 01:00:51PM +0300, Andy Shevchenko wrote:
> > On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:
> > > On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> > > <[email protected]> wrote:
> > > >
> > > > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> > > >
> > > > Signed-off-by: Andy Shevchenko <[email protected]>
> > > Acked-by: Martin Blumenstingl <[email protected]>
> >
> > Thank you!
> >
> > Can it be applied now?
>
> So, this is still not applied, does it mean we need to go via GPIO tree
> with it?

I remember your ping and also answering it, but I cannot find it. Let
me look into this. In any case, apologies for that.

Thanks,
Miquèl