2021-12-27 05:45:37

by Xianwei Zhao

Subject: [PATCH V3] dt-bindings: serial: amlogic, meson-uart: support S4

Add serial bindings support meson S4 SoC family.

Signed-off-by: Xianwei Zhao <[email protected]>
---
V2 -> V3 : fix the type menson->meson
V1 -> V2 : update author name
---
.../devicetree/bindings/serial/amlogic,meson-uart.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
index 7487aa6ef849..72e8868db3e0 100644
--- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
@@ -29,6 +29,7 @@ properties:
- amlogic,meson8-uart
- amlogic,meson8b-uart
- amlogic,meson-gx-uart
+ - amlogic,meson-s4-uart
- const: amlogic,meson-ao-uart
- description: Everything-Else power domain UART controller
enum:
@@ -36,6 +37,7 @@ properties:
- amlogic,meson8-uart
- amlogic,meson8b-uart
- amlogic,meson-gx-uart
+ - amlogic,meson-s4-uart

reg:
maxItems: 1

base-commit: 84184107c39ae65d08f6d449a57ec58734ff535a
--
2.30.2

2021-12-27 15:33:59

by Rob Herring (Arm)

Subject: Re: [PATCH V3] dt-bindings: serial: amlogic, meson-uart: support S4

On Mon, 27 Dec 2021 13:45:29 +0800, Xianwei Zhao wrote:
> Add serial bindings support meson S4 SoC family.
>
> Signed-off-by: Xianwei Zhao <[email protected]>
> ---
> V2 -> V3 : fix the type menson->meson
> V1 -> V2 : update author name
> ---
> .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1573297


serial@23000: 'bluetooth', 'uart-has-rtscts' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dt.yaml

serial@24000: 'bluetooth', 'uart-has-rtscts' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-s922x-khadas-vim3.dt.yaml
arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dt.yaml
arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dt.yaml
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dt.yaml

serial@4c0: clock-names:0: 'xtal' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@4c0: clock-names:1: 'pclk' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@4c0: clock-names:2: 'baud' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@4c0: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/meson6-atv1200.dt.yaml
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@4e0: 'uart-has-rtscts' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dt.yaml

serial@84c0: 'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dt.yaml

serial@84c0: 'bluetooth', 'uart-has-rtscts' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dt.yaml

serial@84c0: clock-names:0: 'xtal' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@84c0: clock-names:1: 'pclk' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@84c0: clock-names:2: 'baud' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@84c0: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/meson6-atv1200.dt.yaml
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@84c0: 'uart-has-rtscts' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dt.yaml
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml

serial@84dc: clock-names:0: 'xtal' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@84dc: clock-names:1: 'pclk' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@84dc: clock-names:2: 'baud' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@84dc: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/meson6-atv1200.dt.yaml
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@84dc: 'uart-has-rtscts' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/meson8b-ec100.dt.yaml

serial@8700: clock-names:0: 'xtal' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@8700: clock-names:1: 'pclk' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@8700: clock-names:2: 'baud' was expected
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

serial@8700: compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm/boot/dts/meson6-atv1200.dt.yaml
arch/arm/boot/dts/meson8b-ec100.dt.yaml
arch/arm/boot/dts/meson8b-mxq.dt.yaml
arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

2021-12-27 16:54:15

by Rob Herring (Arm)

Subject: Re: [PATCH V3] dt-bindings: serial: amlogic, meson-uart: support S4

On Mon, Dec 27, 2021 at 11:33:26AM -0400, Rob Herring wrote:
> On Mon, 27 Dec 2021 13:45:29 +0800, Xianwei Zhao wrote:
> > Add serial bindings support meson S4 SoC family.
> >
> > Signed-off-by: Xianwei Zhao <[email protected]>
> > ---
> > V2 -> V3 : fix the type menson->meson
> > V1 -> V2 : update author name
> > ---
> > .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1573297
>
>
> serial@23000: 'bluetooth', 'uart-has-rtscts' do not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dt.yaml
>
> serial@24000: 'bluetooth', 'uart-has-rtscts' do not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm64/boot/dts/amlogic/meson-axg-s400.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12b-a311d-khadas-vim3.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12b-gsking-x.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12b-gtking-pro.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12b-s922x-khadas-vim3.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dt.yaml
> arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dt.yaml

These are all due to no reference to serial.yaml. Please fix that. We
fixed all of these, so this schema must have come in at the same time.

Rob

2021-12-27 17:08:35

by Martin Blumenstingl

Subject: Re: [PATCH V3] dt-bindings: serial: amlogic, meson-uart: support S4

On Mon, Dec 27, 2021 at 4:33 PM Rob Herring <[email protected]> wrote:
[...]
> serial@84dc: compatible: 'oneOf' conditional failed, one must be fixed:
> arch/arm/boot/dts/meson6-atv1200.dt.yaml
> arch/arm/boot/dts/meson8b-ec100.dt.yaml
> arch/arm/boot/dts/meson8b-mxq.dt.yaml
> arch/arm/boot/dts/meson8b-odroidc1.dt.yaml
> arch/arm/boot/dts/meson8m2-mxiii-plus.dt.yaml
> arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml
The warnings from this section (affecting arch/arm/boot/dts/meson*)
have been there before this patch already.
I am going to send a patch to clean them up so it doesn't cause
further confusion in the future.


Best regards,
Martin