2019-10-08 15:07:08

by Kevin Hilman

Subject: Re: [PATCH] usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource()

Saurav Girepunje <[email protected]> writes:

> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together in dwc3_meson_g12a_probe().
>
> Signed-off-by: Saurav Girepunje <[email protected]>

Reviewed-by: Kevin Hilman <[email protected]>

> ---
> drivers/usb/dwc3/dwc3-meson-g12a.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> index bca7e92a10e9..d73ccd9e1366 100644
> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> @@ -386,7 +386,6 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> void __iomem *base;
> - struct resource *res;
> enum phy_mode otg_id;
> int ret, i, irq;
>
> @@ -394,8 +393,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> --
> 2.20.1

2019-10-08 17:30:43

by Martin Blumenstingl

Subject: Re: [PATCH] usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource()

Hi Saurav,

On Tue, Oct 8, 2019 at 5:06 PM Kevin Hilman <[email protected]> wrote:
>
> Saurav Girepunje <[email protected]> writes:
>
> > Use the new helper that wraps the calls to platform_get_resource()
> > and devm_ioremap_resource() together in dwc3_meson_g12a_probe().
> >
> > Signed-off-by: Saurav Girepunje <[email protected]>
the following commit is already in mainline:

commit c6e4999cd930b8bd11dd8d4767e871b47f502845
Author: YueHaibing <[email protected]>
Date: Fri Aug 2 21:04:08 2019 +0800
usb: dwc3: meson-g12a: use devm_platform_ioremap_resource() to simplify code


Martin