2023-06-14 09:17:08

by Yang Li

Subject: [PATCH -next] clk: meson: Remove unneeded semicolon

./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5531
Signed-off-by: Yang Li <[email protected]>
---
drivers/clk/meson/clk-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 56ec2210f1ad..8fef90bf962f 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -370,7 +370,7 @@ static int meson_clk_pll_enable(struct clk_hw *hw)
usleep_range(10, 20);
meson_parm_write(clk->map, &pll->current_en, 1);
usleep_range(40, 50);
- };
+ }

if (MESON_PARM_APPLICABLE(&pll->l_detect)) {
meson_parm_write(clk->map, &pll->l_detect, 1);
--
2.20.1.7.g153144c

2023-06-14 20:35:23

by Martin Blumenstingl

Subject: Re: [PATCH -next] clk: meson: Remove unneeded semicolon

On Wed, Jun 14, 2023 at 10:40 AM Yang Li <[email protected]> wrote:
>
> ./drivers/clk/meson/clk-pll.c:373:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5531
> Signed-off-by: Yang Li <[email protected]>
An identical patch was sent within minutes of this one: [0]
The other one has two Reviewed-by already. So I think this one should
be discarded.
Still, thanks for following up on this issue!


Best regards,
Martin


[0] https://lore.kernel.org/linux-amlogic/[email protected]/