2020-09-09 16:54:34

by Neil Armstrong

Subject: [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG

This enables USB OTG on the S400 board.

Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index cb1360ae1211..5f131debcbad 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -584,3 +584,13 @@
pinctrl-0 = <&uart_ao_a_pins>;
pinctrl-names = "default";
};
+
+&usb {
+ status = "okay";
+ dr_mode = "otg";
+ vbus-supply = <&usb_pwr>;
+};
+
+&usb2_phy1 {
+ phy-supply = <&vcc_5v>;
+};
--
2.22.0

2020-09-15 20:11:03

by Martin Blumenstingl

Subject: Re: [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG

Hi Neil,

On Wed, Sep 9, 2020 at 6:05 PM Neil Armstrong <[email protected]> wrote:
[...]
> +&usb {
> + status = "okay";
> + dr_mode = "otg";
> + vbus-supply = <&usb_pwr>;
> +};
> +
> +&usb2_phy1 {
> + phy-supply = <&vcc_5v>;
out of curiosity: why do we need this phy-supply here?
isn't the usb_pwr regulator as vbus-supply above enough?


Best regards,
Martin

2020-09-16 07:10:50

by Neil Armstrong

Subject: Re: [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG

On 15/09/2020 22:05, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Wed, Sep 9, 2020 at 6:05 PM Neil Armstrong <[email protected]> wrote:
> [...]
>> +&usb {
>> + status = "okay";
>> + dr_mode = "otg";
>> + vbus-supply = <&usb_pwr>;
>> +};
>> +
>> +&usb2_phy1 {
>> + phy-supply = <&vcc_5v>;
> out of curiosity: why do we need this phy-supply here?
> isn't the usb_pwr regulator as vbus-supply above enough?

Damn you're right !
Thanks for noticing.

Neil

>
>
> Best regards,
> Martin
>