2023-09-13 14:30:27

by Oded Gabbay

[permalink] [raw]
Subject: Re: [PATCH] accel/habanalabs/gaudi2: Fix incorrect string length computation in gaudi2_psoc_razwi_get_engines()

On Tue, Sep 5, 2023 at 3:28 PM Stanislaw Gruszka
<[email protected]> wrote:
>
> On Mon, Sep 04, 2023 at 09:18:36PM +0200, Christophe JAILLET wrote:
> > snprintf() returns the "number of characters which *would* be generated for
> > the given input", not the size *really* generated.
> >
> > In order to avoid too large values for 'str_size' (and potential negative
> > values for "PSOC_RAZWI_ENG_STR_SIZE - str_size") use scnprintf()
> > instead of snprintf().
> >
> > Fixes: c0e6df916050 ("accel/habanalabs: fix address decode RAZWI handling")
> > Signed-off-by: Christophe JAILLET <[email protected]>
> Reviewed-by: Stanislaw Gruszka <[email protected]>
Applied to -next.
Thanks for the patch.
Oded