2021-01-17 21:51:56

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the csky tree

---

Hi all,

In commit

8bfb676492da ("csky: Fix a size determination in gpr_get()")

Fixes tag

Fixes: dcad7854fcce ("sky: switch to ->regset_get()")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2021-01-19 06:32:35

by Zhenzhong Duan

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the csky tree

---

On Mon, Jan 18, 2021 at 5:49 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commit
>
> 8bfb676492da ("csky: Fix a size determination in gpr_get()")
>
> Fixes tag
>
> Fixes: dcad7854fcce ("sky: switch to ->regset_get()")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'

Sorry for the mistake. Should be
'Fixes: dcad7854fcce ("csky: switch to ->regset_get()")'
not
'Fixes: dcad7854fcce ("sky: switch to ->regset_get()")'

Should I send the patch again with above fix?

Thanks
Zhenzhong