2012-08-12 13:59:22

by Arthur Marsh

[permalink] [raw]
Subject: fuse: implement i_op->atomic_open() prevents writes to ntfs-3g filesystem

[repost, apologies if you see it twice]
I'm running Debian unstable on AMD64 (quad core) with Linus' github.com
kernels.

Recently (post 3.5.0 kernels) writes to an ntfs-3g filesystem started
failing, and I bisected back to the following:

# git bisect good
c8ccbe032feb127a977c66865cb63d72d9a6e08b is the first bad commit
commit c8ccbe032feb127a977c66865cb63d72d9a6e08b
Author: Miklos Szeredi <[email protected]>
Date: Tue Jun 5 15:10:22 2012 +0200

fuse: implement i_op->atomic_open()

Add an ->atomic_open implementation which replaces the atomic
open+create
operation implemented via ->create. No functionality is changed.

Signed-off-by: Miklos Szeredi <[email protected]>
Signed-off-by: Al Viro <[email protected]>

:040000 040000 7a000897ad0d1524a7e1cb187bc77d92b8397d56
38f02e55f70b009f8b1149cdd75f571c72406fe4 M fs

Has this problem been seen by anyone else?

Is a fix already in the works?

Regards,

Arthur.


2012-08-12 14:10:07

by Richard Weinberger

[permalink] [raw]
Subject: Re: fuse: implement i_op->atomic_open() prevents writes to ntfs-3g filesystem

On Sun, Aug 12, 2012 at 3:59 PM, Arthur Marsh
<[email protected]> wrote:
> [repost, apologies if you see it twice]
> I'm running Debian unstable on AMD64 (quad core) with Linus' github.com
> kernels.
>
> Recently (post 3.5.0 kernels) writes to an ntfs-3g filesystem started
> failing, and I bisected back to the following:
>
> # git bisect good
> c8ccbe032feb127a977c66865cb63d72d9a6e08b is the first bad commit
> commit c8ccbe032feb127a977c66865cb63d72d9a6e08b
> Author: Miklos Szeredi <[email protected]>
> Date: Tue Jun 5 15:10:22 2012 +0200
>
> fuse: implement i_op->atomic_open()
>
> Add an ->atomic_open implementation which replaces the atomic
> open+create
> operation implemented via ->create. No functionality is changed.
>
> Signed-off-by: Miklos Szeredi <[email protected]>
> Signed-off-by: Al Viro <[email protected]>
>
> :040000 040000 7a000897ad0d1524a7e1cb187bc77d92b8397d56
> 38f02e55f70b009f8b1149cdd75f571c72406fe4 M fs
>
> Has this problem been seen by anyone else?
>
> Is a fix already in the works?

Adding some CCs.

--
Thanks,
//richard

2012-08-12 14:37:52

by Josh Boyer

[permalink] [raw]
Subject: Re: fuse: implement i_op->atomic_open() prevents writes to ntfs-3g filesystem

On Sun, Aug 12, 2012 at 9:59 AM, Arthur Marsh
<[email protected]> wrote:
> [repost, apologies if you see it twice]
> I'm running Debian unstable on AMD64 (quad core) with Linus' github.com
> kernels.
>
> Recently (post 3.5.0 kernels) writes to an ntfs-3g filesystem started
> failing, and I bisected back to the following:
>
> # git bisect good
> c8ccbe032feb127a977c66865cb63d72d9a6e08b is the first bad commit
> commit c8ccbe032feb127a977c66865cb63d72d9a6e08b
> Author: Miklos Szeredi <[email protected]>
> Date: Tue Jun 5 15:10:22 2012 +0200
>
> fuse: implement i_op->atomic_open()
>
> Add an ->atomic_open implementation which replaces the atomic
> open+create
> operation implemented via ->create. No functionality is changed.
>
> Signed-off-by: Miklos Szeredi <[email protected]>
> Signed-off-by: Al Viro <[email protected]>
>
> :040000 040000 7a000897ad0d1524a7e1cb187bc77d92b8397d56
> 38f02e55f70b009f8b1149cdd75f571c72406fe4 M fs
>
> Has this problem been seen by anyone else?

Yep, it was reported in Fedora last week.

> Is a fix already in the works?

Miklos posted this patch series that fixed things:

http://thread.gmane.org/gmane.linux.file-systems/66445/focus=1339000

josh

2012-08-12 16:50:36

by Arthur Marsh

[permalink] [raw]
Subject: Re: fuse: implement i_op->atomic_open() prevents writes to ntfs-3g filesystem



Josh Boyer wrote, on 13/08/12 00:07:
> On Sun, Aug 12, 2012 at 9:59 AM, Arthur Marsh
...
>> Has this problem been seen by anyone else?
>
> Yep, it was reported in Fedora last week.
>
>> Is a fix already in the works?
>
> Miklos posted this patch series that fixed things:
>
> http://thread.gmane.org/gmane.linux.file-systems/66445/focus=1339000
>
> josh
>

Thanks, after applying these 4 patches to the current Linus git head,
the resulting kernel has no problems creating files with ntfs-3g.

Arthur.