2020-10-31 08:59:31

by Chengsong Ke

Subject: [PATCH v2] ubifs: Fix the printing type of c->big_lpt

Ubifs uses %d to print c->big_lpt, but c->big_lpt is a variable
of type unsigned int and should be printed with %u.

Signed-off-by: Chengsong Ke <[email protected]>
---
fs/ubifs/debug.c | 2 +-
fs/ubifs/lpt.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index ebff43f8009c..ef1a02ee076f 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -764,7 +764,7 @@ void ubifs_dump_lpt_info(struct ubifs_info *c)
pr_err("\tnnode_sz: %d\n", c->nnode_sz);
pr_err("\tltab_sz: %d\n", c->ltab_sz);
pr_err("\tlsave_sz: %d\n", c->lsave_sz);
- pr_err("\tbig_lpt: %d\n", c->big_lpt);
+ pr_err("\tbig_lpt: %u\n", c->big_lpt);
pr_err("\tlpt_hght: %d\n", c->lpt_hght);
pr_err("\tpnode_cnt: %d\n", c->pnode_cnt);
pr_err("\tnnode_cnt: %d\n", c->nnode_cnt);
diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c
index 6e0a153b7194..778a22bf9a92 100644
--- a/fs/ubifs/lpt.c
+++ b/fs/ubifs/lpt.c
@@ -851,7 +851,7 @@ int ubifs_create_dflt_lpt(struct ubifs_info *c, int *main_lebs, int lpt_first,
dbg_lp("lsave_sz %d", c->lsave_sz);
dbg_lp("lsave_cnt %d", c->lsave_cnt);
dbg_lp("lpt_hght %d", c->lpt_hght);
- dbg_lp("big_lpt %d", c->big_lpt);
+ dbg_lp("big_lpt %u", c->big_lpt);
dbg_lp("LPT root is at %d:%d", c->lpt_lnum, c->lpt_offs);
dbg_lp("LPT head is at %d:%d", c->nhead_lnum, c->nhead_offs);
dbg_lp("LPT ltab is at %d:%d", c->ltab_lnum, c->ltab_offs);
@@ -1824,7 +1824,7 @@ static int lpt_init_rd(struct ubifs_info *c)
dbg_lp("lsave_sz %d", c->lsave_sz);
dbg_lp("lsave_cnt %d", c->lsave_cnt);
dbg_lp("lpt_hght %d", c->lpt_hght);
- dbg_lp("big_lpt %d", c->big_lpt);
+ dbg_lp("big_lpt %u", c->big_lpt);
dbg_lp("LPT root is at %d:%d", c->lpt_lnum, c->lpt_offs);
dbg_lp("LPT head is at %d:%d", c->nhead_lnum, c->nhead_offs);
dbg_lp("LPT ltab is at %d:%d", c->ltab_lnum, c->ltab_offs);
--
2.12.3

2020-10-31 20:48:17

by Richard Weinberger

Subject: Re: [PATCH v2] ubifs: Fix the printing type of c->big_lpt

On Sat, Oct 31, 2020 at 9:56 AM Chengsong Ke <[email protected]> wrote:
>
> Ubifs uses %d to print c->big_lpt, but c->big_lpt is a variable
> of type unsigned int and should be printed with %u.

Well, it is:
unsigned int big_lpt:1;
So, either 0 or 1.

Does changing it to %u silence some static checker or is there some
other problem I don't
see right now? :-)

Thanks,
//richard

2020-11-02 07:50:07

by Chengsong Ke

Subject: Re: [PATCH v2] ubifs: Fix the printing type of c->big_lpt

On Sat, Oct 31, 2020 at 9:56 AM Chengsong Ke <[email protected]> wrote:
>
> Ubifs uses %d to print c->big_lpt, but c->big_lpt is a variable of
> type unsigned int and should be printed with %u.
>
> Well, it is:
> unsigned int big_lpt:1;
> So, either 0 or 1.
>
> Does changing it to %u silence some static checker or is there some other problem I don't see right now? :-)
>
> Thanks,
> //Richard

This is just a coding style issue, I found in the ubifs code. :-)
Thanks,
//Chengsong Ke

2020-11-02 09:17:42

by Chengsong Ke

Subject: Re: [PATCH v2] ubifs: Fix the printing type of c->big_lpt

On Sat, Oct 31, 2020 at 9:56 AM Chengsong Ke <[email protected]> wrote:
>
> Ubifs uses %d to print c->big_lpt, but c->big_lpt is a variable of
> type unsigned int and should be printed with %u.
>
> Well, it is:
> unsigned int big_lpt:1;
> So, either 0 or 1.
>
> Does changing it to %u silence some static checker or is there some
> other problem I don't see right now? :-)
>
> Thanks,
> //Richard

This is just a coding style issue, I found in the ubifs code. :-)
Thanks,
//Chengsong Ke