2019-05-06 21:25:28

by Vandana BN

Subject: [PATCH] fs: ubifs: Resolve sparse warning for using plain integer as NULL pointer

fs/ubifs/xattr.c:615:58: warning: Using plain integer as NULL pointer

Signed-off-by: Vandana BN <[email protected]>
---
fs/ubifs/xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
index f5ad1ede7990..066a5666c50f 100644
--- a/fs/ubifs/xattr.c
+++ b/fs/ubifs/xattr.c
@@ -612,7 +612,7 @@ int ubifs_init_security(struct inode *dentry, struct inode *inode,
int err;

err = security_inode_init_security(inode, dentry, qstr,
- &init_xattrs, 0);
+ &init_xattrs, NULL);
if (err) {
struct ubifs_info *c = dentry->i_sb->s_fs_info;
ubifs_err(c, "cannot initialize security for inode %lu, error %d",
--
2.17.1

2019-05-15 21:08:55

by Richard Weinberger

Subject: Re: [PATCH] fs: ubifs: Resolve sparse warning for using plain integer as NULL pointer

On Mon, May 6, 2019 at 11:24 PM Vandana BN <[email protected]> wrote:
>
> fs/ubifs/xattr.c:615:58: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Vandana BN <[email protected]>
> ---
> fs/ubifs/xattr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
> index f5ad1ede7990..066a5666c50f 100644
> --- a/fs/ubifs/xattr.c
> +++ b/fs/ubifs/xattr.c
> @@ -612,7 +612,7 @@ int ubifs_init_security(struct inode *dentry, struct inode *inode,
> int err;
>
> err = security_inode_init_security(inode, dentry, qstr,
> - &init_xattrs, 0);
> + &init_xattrs, NULL);
> if (err) {
> struct ubifs_info *c = dentry->i_sb->s_fs_info;
> ubifs_err(c, "cannot initialize security for inode %lu, error %d",
> --
> 2.17.1

Applied.

--
Thanks,
//richard