2021-06-23 04:58:29

by Hsin-Hsiung Wang

[permalink] [raw]
Subject: [PATCH] regulator: mt6358: Fix vdram2 .vsel_mask

The valid vsel value are 0 and 12, so the .vsel_mask should be 0xf.

Signed-off-by: Hsin-Hsiung Wang <[email protected]>
---
drivers/regulator/mt6358-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/mt6358-regulator.c b/drivers/regulator/mt6358-regulator.c
index 13cb6ac9a892..1d4eb5dc4fac 100644
--- a/drivers/regulator/mt6358-regulator.c
+++ b/drivers/regulator/mt6358-regulator.c
@@ -457,7 +457,7 @@ static struct mt6358_regulator_info mt6358_regulators[] = {
MT6358_REG_FIXED("ldo_vaud28", VAUD28,
MT6358_LDO_VAUD28_CON0, 0, 2800000),
MT6358_LDO("ldo_vdram2", VDRAM2, vdram2_voltages, vdram2_idx,
- MT6358_LDO_VDRAM2_CON0, 0, MT6358_LDO_VDRAM2_ELR0, 0x10, 0),
+ MT6358_LDO_VDRAM2_CON0, 0, MT6358_LDO_VDRAM2_ELR0, 0xf, 0),
MT6358_LDO("ldo_vsim1", VSIM1, vsim_voltages, vsim_idx,
MT6358_LDO_VSIM1_CON0, 0, MT6358_VSIM1_ANA_CON0, 0xf00, 8),
MT6358_LDO("ldo_vibr", VIBR, vibr_voltages, vibr_idx,
--
2.18.0


2021-06-23 05:05:07

by Axel Lin

[permalink] [raw]
Subject: Re: [PATCH] regulator: mt6358: Fix vdram2 .vsel_mask

Hsin-Hsiung Wang <[email protected]> 於 2021年6月23日 週三 下午12:56寫道:
>
> The valid vsel value are 0 and 12, so the .vsel_mask should be 0xf.
>
> Signed-off-by: Hsin-Hsiung Wang <[email protected]>
Reviewed-by: Axel Lin <[email protected]>

2021-06-23 16:10:30

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: mt6358: Fix vdram2 .vsel_mask

On Wed, 23 Jun 2021 12:56:09 +0800, Hsin-Hsiung Wang wrote:
> The valid vsel value are 0 and 12, so the .vsel_mask should be 0xf.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: mt6358: Fix vdram2 .vsel_mask
commit: 50c9462edcbf900f3d5097ca3ad60171346124de

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark