2021-06-26 15:59:55

by ChiYuan Huang

[permalink] [raw]
Subject: [PATCH] regulator: rtmv20: Fix wrong mask for strobe-polarity-high

From: ChiYuan Huang <[email protected]>

Fix wrong mask for strobe-polarity-high.

Signed-off-by: ChiYuan Huang <[email protected]>
In-reply-to: <CAFRkauB=0KwrJW19nJTTagdHhBR=V2R8YFWG3R3oVXt=rBRsqw@mail.gmail.com>
---
Sorry, it's really the typo.
This mask must be bit 0 not 1.
---
drivers/regulator/rtmv20-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/rtmv20-regulator.c b/drivers/regulator/rtmv20-regulator.c
index 4bca64d..2ee3341 100644
--- a/drivers/regulator/rtmv20-regulator.c
+++ b/drivers/regulator/rtmv20-regulator.c
@@ -37,7 +37,7 @@
#define RTMV20_WIDTH2_MASK GENMASK(7, 0)
#define RTMV20_LBPLVL_MASK GENMASK(3, 0)
#define RTMV20_LBPEN_MASK BIT(7)
-#define RTMV20_STROBEPOL_MASK BIT(1)
+#define RTMV20_STROBEPOL_MASK BIT(0)
#define RTMV20_VSYNPOL_MASK BIT(1)
#define RTMV20_FSINEN_MASK BIT(7)
#define RTMV20_ESEN_MASK BIT(6)
--
2.7.4


2021-06-26 16:16:29

by Axel Lin

[permalink] [raw]
Subject: Re: [PATCH] regulator: rtmv20: Fix wrong mask for strobe-polarity-high

cy_huang <[email protected]> 於 2021年6月26日 週六 下午11:58寫道:
>
> From: ChiYuan Huang <[email protected]>
>
> Fix wrong mask for strobe-polarity-high.
>
> Signed-off-by: ChiYuan Huang <[email protected]>
Reviewed-by: Axel Lin <[email protected]>

2021-06-28 23:59:29

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: rtmv20: Fix wrong mask for strobe-polarity-high

On Sat, 26 Jun 2021 23:58:32 +0800, cy_huang wrote:
> Fix wrong mask for strobe-polarity-high.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: rtmv20: Fix wrong mask for strobe-polarity-high
commit: 2b6a761be079f9fa8abf3157b5679a6f38885db4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark