2014-06-08 06:57:46

by Chen Gang

Subject: [PATCH] arch/score/kernel/process.c: Remove useless varialbes 'ti' and 'regs'

They are useless, so remove them, the related warning (with
allmodconfig under score):

CC arch/score/kernel/process.o
arch/score/kernel/process.c: In function 'copy_thread':
arch/score/kernel/process.c:76:18: warning: unused variable 'regs' [-Wunused-variable]
struct pt_regs *regs = current_pt_regs();
^
arch/score/kernel/process.c:74:22: warning: unused variable 'ti' [-Wunused-variable]
struct thread_info *ti = task_thread_info(p);
^

Signed-off-by: Chen Gang <[email protected]>
---
arch/score/kernel/process.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/score/kernel/process.c b/arch/score/kernel/process.c
index a1519ad3..50bf1b0 100644
--- a/arch/score/kernel/process.c
+++ b/arch/score/kernel/process.c
@@ -71,9 +71,7 @@ void flush_thread(void) {}
int copy_thread(unsigned long clone_flags, unsigned long usp,
unsigned long arg, struct task_struct *p)
{
- struct thread_info *ti = task_thread_info(p);
struct pt_regs *childregs = task_pt_regs(p);
- struct pt_regs *regs = current_pt_regs();

p->thread.reg0 = (unsigned long) childregs;
if (unlikely(p->flags & PF_KTHREAD)) {
--
1.7.11.7

2014-06-12 09:52:46

by Liqin Chen

Subject: Re: [PATCH] arch/score/kernel/process.c: Remove useless varialbes 'ti' and 'regs'

It's ok for S+core
Thanks.

Acked-by: Chen Liqin<[email protected]>

2014-06-08 14:58 GMT+08:00 Chen Gang <[email protected]>:
> They are useless, so remove them, the related warning (with
> allmodconfig under score):
>
> CC arch/score/kernel/process.o
> arch/score/kernel/process.c: In function 'copy_thread':
> arch/score/kernel/process.c:76:18: warning: unused variable 'regs' [-Wunused-variable]
> struct pt_regs *regs = current_pt_regs();
> ^
> arch/score/kernel/process.c:74:22: warning: unused variable 'ti' [-Wunused-variable]
> struct thread_info *ti = task_thread_info(p);
> ^
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/score/kernel/process.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/score/kernel/process.c b/arch/score/kernel/process.c
> index a1519ad3..50bf1b0 100644
> --- a/arch/score/kernel/process.c
> +++ b/arch/score/kernel/process.c
> @@ -71,9 +71,7 @@ void flush_thread(void) {}
> int copy_thread(unsigned long clone_flags, unsigned long usp,
> unsigned long arg, struct task_struct *p)
> {
> - struct thread_info *ti = task_thread_info(p);
> struct pt_regs *childregs = task_pt_regs(p);
> - struct pt_regs *regs = current_pt_regs();
>
> p->thread.reg0 = (unsigned long) childregs;
> if (unlikely(p->flags & PF_KTHREAD)) {
> --
> 1.7.11.7