2023-03-19 23:47:36

by Chris Healy

Subject: [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY

From: Chris Healy <[email protected]>

The imx53 base imx53qsb uses an SMSC Ethernet PHY. Enable it's driver.

Signed-off-by: Chris Healy <[email protected]>
---
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 6dc6fed12af8..a12d45e99782 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
CONFIG_MICREL_PHY=y
CONFIG_AT803X_PHY=y
+CONFIG_SMSC_PHY=y
CONFIG_CAN_FLEXCAN=y
CONFIG_USB_PEGASUS=m
CONFIG_USB_RTL8150=m
--
2.39.2

2023-03-20 03:07:17

by Fabio Estevam

Subject: Re: [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY

Hi Chris,

On Sun, Mar 19, 2023 at 8:47 PM Chris Healy <[email protected]> wrote:
>
> From: Chris Healy <[email protected]>
>
> The imx53 base imx53qsb uses an SMSC Ethernet PHY. Enable it's driver.
>
> Signed-off-by: Chris Healy <[email protected]>
> ---
> arch/arm/configs/imx_v6_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 6dc6fed12af8..a12d45e99782 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
> # CONFIG_NET_VENDOR_STMICRO is not set
> CONFIG_MICREL_PHY=y
> CONFIG_AT803X_PHY=y
> +CONFIG_SMSC_PHY=y

Running 'make imx_v6_v7_defconfig' causes CONFIG_SMSC_PHY=y to be
selected by default
because USB_NET_SMSC95XX is already enabled.

It seems that we don't need to explicitly select CONFIG_SMSC_PHY=y as
done in this patch.

2023-03-20 14:01:22

by Chris Healy

Subject: Re: [PATCH 1/1] ARM: imx_v6_v7_defconfig: Enable SMSC Ethernet PHY

On Sun, Mar 19, 2023 at 8:07 PM Fabio Estevam <[email protected]> wrote:
>
> Hi Chris,
>
> On Sun, Mar 19, 2023 at 8:47 PM Chris Healy <[email protected]> wrote:
> >
> > From: Chris Healy <[email protected]>
> >
> > The imx53 base imx53qsb uses an SMSC Ethernet PHY. Enable it's driver.
> >
> > Signed-off-by: Chris Healy <[email protected]>
> > ---
> > arch/arm/configs/imx_v6_v7_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> > index 6dc6fed12af8..a12d45e99782 100644
> > --- a/arch/arm/configs/imx_v6_v7_defconfig
> > +++ b/arch/arm/configs/imx_v6_v7_defconfig
> > @@ -135,6 +135,7 @@ CONFIG_SMSC911X=y
> > # CONFIG_NET_VENDOR_STMICRO is not set
> > CONFIG_MICREL_PHY=y
> > CONFIG_AT803X_PHY=y
> > +CONFIG_SMSC_PHY=y
>
> Running 'make imx_v6_v7_defconfig' causes CONFIG_SMSC_PHY=y to be
> selected by default
> because USB_NET_SMSC95XX is already enabled.
>
> It seems that we don't need to explicitly select CONFIG_SMSC_PHY=y as
> done in this patch.

I see what you are saying. I agree this patch is no longer necessary. Tnx.