2020-07-08 00:36:19

by Chris Healy

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device

Update MDIO configuration with zii-ultra device to fully utilize
MDIO endpoint capabilities. Device supports 12.5MHz clock and
doesn't require MDIO preamble.

Signed-off-by: Chris Healy <[email protected]>
---
v2:
- Fix subject line to reference zii-ultra:
- Get rid of "=<1>;" from suppress-preamble lines

arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 6a55165bd76a..98aa67a4c040 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -132,6 +132,8 @@
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
+ suppress-preamble;
+ clock-frequency = <12500000>;

switch: switch@0 {
compatible = "marvell,mv88e6085";
--
2.21.3


2020-07-08 01:23:34

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device

Hi Chris,

On Tue, Jul 7, 2020 at 9:32 PM Chris Healy <[email protected]> wrote:

> #address-cells = <1>;
> #size-cells = <0>;
> status = "okay";
> + suppress-preamble;
> + clock-frequency = <12500000>;

Sorry, I missed this in the previous review.

The recommendation is to have status = okay as the last property.

Please move suppress-preamble and clock-frequency = <12500000> prior
to status = "okay"

2020-07-08 01:25:52

by Chris Healy

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device

On Tue, Jul 7, 2020 at 5:41 PM Fabio Estevam <[email protected]> wrote:
>
> Hi Chris,
>
> On Tue, Jul 7, 2020 at 9:32 PM Chris Healy <[email protected]> wrote:
>
> > #address-cells = <1>;
> > #size-cells = <0>;
> > status = "okay";
> > + suppress-preamble;
> > + clock-frequency = <12500000>;
>
> Sorry, I missed this in the previous review.
>
> The recommendation is to have status = okay as the last property.
>
> Please move suppress-preamble and clock-frequency = <12500000> prior
> to status = "okay"

Will do in the next version.