2012-10-01 11:05:49

by Will Newton

Subject: Re: [PATCH 03/12] mmc: dw_mmc: fix building exynos driver as a module

On Fri, Sep 28, 2012 at 10:36 PM, Arnd Bergmann <[email protected]> wrote:
> The MODULE_DEVICE_TABLE() entry in the dw_mmc_exynos driver
> points to the wrong symbol which results in a link error
> when building as a loadable module.
>
> Further, we get a warning about the driver_data being
> marked constant, which requires annotating a few pointers
> as const.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Cc: Chris Ball <[email protected]>
> Cc: Thomas Abraham <[email protected]>
> Cc: Will Newton <[email protected]>
> Cc: Jaehoon Chung <[email protected]>
> Cc: Seungwon Jeon <[email protected]>
> Cc: Kyungmin Park <[email protected]>
> Cc: [email protected]
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 4 ++--
> drivers/mmc/host/dw_mmc-pltfm.c | 2 +-
> drivers/mmc/host/dw_mmc-pltfm.h | 2 +-
> drivers/mmc/host/dw_mmc.c | 2 +-
> include/linux/mmc/dw_mmc.h | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)

This looks ok to me, but I'll let one of the Exynos guys ack those
specific changes as I don't have the hardware.

There's already a patch for the dev_info warning in dw_mmc.c frm
Seungwon Jeon, and it seems to me like a separate change but I don't
really mind how it gets merged.

2012-10-04 12:41:04

by Seungwon Jeon

Subject: RE: [PATCH 03/12] mmc: dw_mmc: fix building exynos driver as a module

Monday, October 01, 2012, Will Newton <[email protected]> wrote:
> On Fri, Sep 28, 2012 at 10:36 PM, Arnd Bergmann <[email protected]> wrote:
> > The MODULE_DEVICE_TABLE() entry in the dw_mmc_exynos driver
> > points to the wrong symbol which results in a link error
> > when building as a loadable module.
> >
> > Further, we get a warning about the driver_data being
> > marked constant, which requires annotating a few pointers
> > as const.
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > Cc: Chris Ball <[email protected]>
> > Cc: Thomas Abraham <[email protected]>
> > Cc: Will Newton <[email protected]>
> > Cc: Jaehoon Chung <[email protected]>
> > Cc: Seungwon Jeon <[email protected]>
> > Cc: Kyungmin Park <[email protected]>
> > Cc: [email protected]
> > ---
> > drivers/mmc/host/dw_mmc-exynos.c | 4 ++--
> > drivers/mmc/host/dw_mmc-pltfm.c | 2 +-
> > drivers/mmc/host/dw_mmc-pltfm.h | 2 +-
> > drivers/mmc/host/dw_mmc.c | 2 +-
> > include/linux/mmc/dw_mmc.h | 2 +-
> > 5 files changed, 6 insertions(+), 6 deletions(-)
>
> This looks ok to me, but I'll let one of the Exynos guys ack those
> specific changes as I don't have the hardware.
>
> There's already a patch for the dev_info warning in dw_mmc.c frm
> Seungwon Jeon, and it seems to me like a separate change but I don't
> really mind how it gets merged.

Looks good to me.
I don't mind it about including 'dev_info warning'.

Acked-by: Seungwon Jeon<[email protected]>

> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html