2020-07-07 14:49:20

by SeongJae Park

Subject: [RFC v5 03/11] mm/damon-test: Add more unit tests for 'init_regions'

From: SeongJae Park <[email protected]>

This commit adds more test cases for the new feature, 'init_regions'.

Signed-off-by: SeongJae Park <[email protected]>
---
mm/damon-test.h | 53 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)

diff --git a/mm/damon-test.h b/mm/damon-test.h
index b31c7fe913ca..716594342ff1 100644
--- a/mm/damon-test.h
+++ b/mm/damon-test.h
@@ -152,6 +152,58 @@ static void damon_test_set_recording(struct kunit *test)
KUNIT_EXPECT_STREQ(test, ctx->rfile_path, "foo");
}

+static void damon_test_set_init_regions(struct kunit *test)
+{
+ struct damon_ctx *ctx = &damon_user_ctx;
+ int pids[] = {1, 2, 3};
+ /* Each line represents one region in ``<pid> <start> <end>`` */
+ char * const valid_inputs[] = {"2 10 20\n 2 20 30\n2 35 45",
+ "2 10 20\n",
+ "2 10 20\n1 39 59\n1 70 134\n 2 20 25\n",
+ ""};
+ /* Reading the file again will show sorted, clean output */
+ char * const valid_expects[] = {"2 10 20\n2 20 30\n2 35 45\n",
+ "2 10 20\n",
+ "1 39 59\n1 70 134\n2 10 20\n2 20 25\n",
+ ""};
+ char * const invalid_inputs[] = {"4 10 20\n", /* pid not exists */
+ "2 10 20\n 2 14 26\n", /* regions overlap */
+ "1 10 20\n2 30 40\n 1 5 8"}; /* not sorted by address */
+ char *input, *expect;
+ int i, rc;
+ char buf[256];
+
+ damon_set_pids(ctx, pids, 3);
+
+ /* Put valid inputs and check the results */
+ for (i = 0; i < ARRAY_SIZE(valid_inputs); i++) {
+ input = valid_inputs[i];
+ expect = valid_expects[i];
+
+ rc = set_init_regions(ctx, input, strnlen(input, 256));
+ KUNIT_EXPECT_EQ(test, rc, 0);
+
+ memset(buf, 0, 256);
+ sprint_init_regions(ctx, buf, 256);
+
+ KUNIT_EXPECT_STREQ(test, (char *)buf, expect);
+ }
+ /* Put invlid inputs and check the return error code */
+ for (i = 0; i < ARRAY_SIZE(invalid_inputs); i++) {
+ input = invalid_inputs[i];
+ pr_info("input: %s\n", input);
+ rc = set_init_regions(ctx, input, strnlen(input, 256));
+ KUNIT_EXPECT_EQ(test, rc, -EINVAL);
+
+ memset(buf, 0, 256);
+ sprint_init_regions(ctx, buf, 256);
+
+ KUNIT_EXPECT_STREQ(test, (char *)buf, "");
+ }
+
+ damon_set_pids(ctx, NULL, 0);
+}
+
static void __link_vmas(struct vm_area_struct *vmas, ssize_t nr_vmas)
{
int i, j;
@@ -635,6 +687,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_regions),
KUNIT_CASE(damon_test_set_pids),
KUNIT_CASE(damon_test_set_recording),
+ KUNIT_CASE(damon_test_set_init_regions),
KUNIT_CASE(damon_test_three_regions_in_vmas),
KUNIT_CASE(damon_test_aggregate),
KUNIT_CASE(damon_test_write_rbuf),
--
2.17.1

2020-07-07 20:03:35

by Brendan Higgins

Subject: Re: [RFC v5 03/11] mm/damon-test: Add more unit tests for 'init_regions'

On Tue, Jul 7, 2020 at 7:47 AM SeongJae Park <[email protected]> wrote:
>
> From: SeongJae Park <[email protected]>
>
> This commit adds more test cases for the new feature, 'init_regions'.
>
> Signed-off-by: SeongJae Park <[email protected]>

Reviewed-by: Brendan Higgins <[email protected]>