2020-06-26 21:11:23

by Brendan Higgins

Subject: [PATCH v5 02/12] arch: arm64: add linker section for KUnit test suites

Add a linker section to arm64 where KUnit can put references to its test
suites. This patch is an early step in transitioning to dispatching all
KUnit tests from a centralized executor rather than having each as its
own separate late_initcall.

Signed-off-by: Brendan Higgins <[email protected]>
---
arch/arm64/kernel/vmlinux.lds.S | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S
index 6827da7f3aa54..a1cae9cc655d7 100644
--- a/arch/arm64/kernel/vmlinux.lds.S
+++ b/arch/arm64/kernel/vmlinux.lds.S
@@ -181,6 +181,9 @@ SECTIONS
INIT_RAM_FS
*(.init.rodata.* .init.bss) /* from the EFI stub */
}
+ .kunit_test_suites : {
+ KUNIT_TEST_SUITES
+ }
.exit.data : {
EXIT_DATA
}
--
2.27.0.212.ge8ba1cc988-goog

2020-06-26 21:23:41

by Kees Cook

Subject: Re: [PATCH v5 02/12] arch: arm64: add linker section for KUnit test suites

On Fri, Jun 26, 2020 at 02:09:07PM -0700, Brendan Higgins wrote:
> Add a linker section to arm64 where KUnit can put references to its test
> suites. This patch is an early step in transitioning to dispatching all
> KUnit tests from a centralized executor rather than having each as its
> own separate late_initcall.
>
> Signed-off-by: Brendan Higgins <[email protected]>
> ---
> arch/arm64/kernel/vmlinux.lds.S | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S
> index 6827da7f3aa54..a1cae9cc655d7 100644
> --- a/arch/arm64/kernel/vmlinux.lds.S
> +++ b/arch/arm64/kernel/vmlinux.lds.S
> @@ -181,6 +181,9 @@ SECTIONS
> INIT_RAM_FS
> *(.init.rodata.* .init.bss) /* from the EFI stub */
> }
> + .kunit_test_suites : {
> + KUNIT_TEST_SUITES
> + }

See my reply to 01/12. Then this patch can be dropped. :)

> .exit.data : {
> EXIT_DATA
> }
> --
> 2.27.0.212.ge8ba1cc988-goog
>

--
Kees Cook

2020-06-26 21:25:53

by Brendan Higgins

Subject: Re: [PATCH v5 02/12] arch: arm64: add linker section for KUnit test suites

On Fri, Jun 26, 2020 at 2:20 PM Kees Cook <[email protected]> wrote:
>
> On Fri, Jun 26, 2020 at 02:09:07PM -0700, Brendan Higgins wrote:
> > Add a linker section to arm64 where KUnit can put references to its test
> > suites. This patch is an early step in transitioning to dispatching all
> > KUnit tests from a centralized executor rather than having each as its
> > own separate late_initcall.
> >
> > Signed-off-by: Brendan Higgins <[email protected]>
> > ---
> > arch/arm64/kernel/vmlinux.lds.S | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S
> > index 6827da7f3aa54..a1cae9cc655d7 100644
> > --- a/arch/arm64/kernel/vmlinux.lds.S
> > +++ b/arch/arm64/kernel/vmlinux.lds.S
> > @@ -181,6 +181,9 @@ SECTIONS
> > INIT_RAM_FS
> > *(.init.rodata.* .init.bss) /* from the EFI stub */
> > }
> > + .kunit_test_suites : {
> > + KUNIT_TEST_SUITES
> > + }
>
> See my reply to 01/12. Then this patch can be dropped. :)

Sweet, presumably this one and others.

> > .exit.data : {
> > EXIT_DATA
> > }
> > --
> > 2.27.0.212.ge8ba1cc988-goog
> >
>
> --
> Kees Cook