'default N' should be 'default n', though they happen to have the same
effect here, due to undefined symbols (N in this case) evaluating to n
in a tristate sense.
Remove the default instead of changing it. bool and tristate symbols
implicitly default to n.
Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.
Signed-off-by: Ulf Magnusson <[email protected]>
---
Changes in v2:
Make it clear that Kconfig is involved.
drivers/pci/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index a4ed7484d127..dc8a2a175f19 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
config VMD
depends on PCI_MSI && X86_64 && SRCU
tristate "Intel Volume Management Device Driver"
- default N
---help---
Adds support for the Intel Volume Management Device (VMD). VMD is a
secondary PCI host bridge that allows PCI Express root ports,
--
2.14.1
On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
s/bool/Bool/
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson <[email protected]>
Acked-by: Bjorn Helgaas <[email protected]>
Since only this patch was posted to linux-pci, I assume it will be merged
via some other tree.
> ---
> Changes in v2:
> Make it clear that Kconfig is involved.
>
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
> config VMD
> depends on PCI_MSI && X86_64 && SRCU
> tristate "Intel Volume Management Device Driver"
> - default N
> ---help---
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> secondary PCI host bridge that allows PCI Express root ports,
> --
> 2.14.1
>
On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <[email protected]> wrote:
> On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
>> 'default N' should be 'default n', though they happen to have the same
>> effect here, due to undefined symbols (N in this case) evaluating to n
>> in a tristate sense.
>>
>> Remove the default instead of changing it. bool and tristate symbols
>> implicitly default to n.
>
> s/bool/Bool/
Not a great excuse, but I was thinking syntactically -- 'bool' and
'tristate' symbols... :)
>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <[email protected]>
>
> Acked-by: Bjorn Helgaas <[email protected]>
>
> Since only this patch was posted to linux-pci, I assume it will be merged
> via some other tree.
I didn't have a particular tree in mind for this patchset. I imagined
people would pick up patches into the trees where they make the most
sense, and only created the patchset to keep track of the patches more
easily. Might have created some confusion in retrospect.
I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
individual patches by the way.
Cheers,
Ulf
On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote:
> On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <[email protected]> wrote:
> > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> >> 'default N' should be 'default n', though they happen to have the same
> >> effect here, due to undefined symbols (N in this case) evaluating to n
> >> in a tristate sense.
> >>
> >> Remove the default instead of changing it. bool and tristate symbols
> >> implicitly default to n.
> >
> > s/bool/Bool/
>
> Not a great excuse, but I was thinking syntactically -- 'bool' and
> 'tristate' symbols... :)
>
> >
> >> Discovered with the
> >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> >> script.
> >>
> >> Signed-off-by: Ulf Magnusson <[email protected]>
> >
> > Acked-by: Bjorn Helgaas <[email protected]>
> >
> > Since only this patch was posted to linux-pci, I assume it will be merged
> > via some other tree.
>
> I didn't have a particular tree in mind for this patchset. I imagined
> people would pick up patches into the trees where they make the most
> sense, and only created the patchset to keep track of the patches more
> easily. Might have created some confusion in retrospect.
>
> I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
> individual patches by the way.
OK, then either Lorenzo or I will pick it up.
It's in drivers/pci/host/, so ideally Lorenzo will take it since he
looks after everything else in there.
Bjorn
On Thu, Feb 22, 2018 at 06:21:42PM -0600, Bjorn Helgaas wrote:
> On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote:
> > On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <[email protected]> wrote:
> > > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> > >> 'default N' should be 'default n', though they happen to have the same
> > >> effect here, due to undefined symbols (N in this case) evaluating to n
> > >> in a tristate sense.
> > >>
> > >> Remove the default instead of changing it. bool and tristate symbols
> > >> implicitly default to n.
> > >
> > > s/bool/Bool/
> >
> > Not a great excuse, but I was thinking syntactically -- 'bool' and
> > 'tristate' symbols... :)
> >
> > >
> > >> Discovered with the
> > >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> > >> script.
> > >>
> > >> Signed-off-by: Ulf Magnusson <[email protected]>
> > >
> > > Acked-by: Bjorn Helgaas <[email protected]>
> > >
> > > Since only this patch was posted to linux-pci, I assume it will be merged
> > > via some other tree.
> >
> > I didn't have a particular tree in mind for this patchset. I imagined
> > people would pick up patches into the trees where they make the most
> > sense, and only created the patchset to keep track of the patches more
> > easily. Might have created some confusion in retrospect.
> >
> > I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
> > individual patches by the way.
>
> OK, then either Lorenzo or I will pick it up.
>
> It's in drivers/pci/host/, so ideally Lorenzo will take it since he
> looks after everything else in there.
Sure I will take it, thanks.
Lorenzo
On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
I have remove this link - it can become stale so I do not think it is
worth adding it to the log.
I have also reworded the $SUBJECT.
Applied to pci/host/misc for v4.17, let me know if that's fine for you.
Thanks,
Lorenzo
> Signed-off-by: Ulf Magnusson <[email protected]>
> ---
> Changes in v2:
> Make it clear that Kconfig is involved.
>
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
> config VMD
> depends on PCI_MSI && X86_64 && SRCU
> tristate "Intel Volume Management Device Driver"
> - default N
> ---help---
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> secondary PCI host bridge that allows PCI Express root ports,
> --
> 2.14.1
>