2014-10-14 21:35:01

by Rickard Strandqvist

[permalink] [raw]
Subject: Re: [PATCH] staging: lustre: lustre: libcfs: debug.c: Cleaning up unnecessary use of memset in conjunction with strncpy

2014-09-19 0:39 GMT+02:00 Dan Carpenter <[email protected]>:
> On Thu, Sep 18, 2014 at 09:57:17PM +0200, Rickard Strandqvist wrote:
>>
>> Should I add this as a patch in lib/string.c or email him first.. What
>> is customary in these situations?
>>
>
> Just write up a normal patch and try to merge it through the normal
> methods.
>
> It's not that controversial to do:
>
> strncpy(dest, src, n);
> dest[n] = '\0';
>
> That's what we have been open coding all over the place anyway already.


Hi Dan!

I have tried the function strzcpy that we talk about, but it has not
happened anything:-(

Is there anything else I can do?


Kind regards
Rickard Strandqvist