2019-06-19 00:17:03

by Bjorn Andersson

Subject: [PATCH v2] arm64: dts: qcom: msm8996: Rename smmu nodes

Node names shouldn't include a vendor prefix and should whenever
possible use a generic identifier. Resolve this by renaming the smmu
nodes "iommu".

Signed-off-by: Bjorn Andersson <[email protected]>
---

Changes since v1:
- Updated commit message to talk about vendor prefix rather than qcom,

arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 2ecd9d775d61..c934e00434c7 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -1163,7 +1163,7 @@
};
};

- vfe_smmu: arm,smmu@da0000 {
+ vfe_smmu: iommu@da0000 {
compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
reg = <0xda0000 0x10000>;

@@ -1314,7 +1314,7 @@
};
};

- adreno_smmu: arm,smmu@b40000 {
+ adreno_smmu: iommu@b40000 {
compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
reg = <0xb40000 0x10000>;

@@ -1331,7 +1331,7 @@
power-domains = <&mmcc GPU_GDSC>;
};

- mdp_smmu: arm,smmu@d00000 {
+ mdp_smmu: iommu@d00000 {
compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
reg = <0xd00000 0x10000>;

@@ -1347,7 +1347,7 @@
power-domains = <&mmcc MDSS_GDSC>;
};

- lpass_q6_smmu: arm,smmu-lpass_q6@1600000 {
+ lpass_q6_smmu: iommu@1600000 {
compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
reg = <0x1600000 0x20000>;
#iommu-cells = <1>;
--
2.18.0

2019-06-25 08:15:31

by Vivek Gautam

Subject: Re: [PATCH v2] arm64: dts: qcom: msm8996: Rename smmu nodes

On Wed, Jun 19, 2019 at 5:46 AM Bjorn Andersson
<[email protected]> wrote:
>
> Node names shouldn't include a vendor prefix and should whenever
> possible use a generic identifier. Resolve this by renaming the smmu
> nodes "iommu".

The bindings too say so :)
Reviewed-by: Vivek Gautam <[email protected]>

>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
>
> Changes since v1:
> - Updated commit message to talk about vendor prefix rather than qcom,
>
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 2ecd9d775d61..c934e00434c7 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1163,7 +1163,7 @@
> };
> };
>
> - vfe_smmu: arm,smmu@da0000 {
> + vfe_smmu: iommu@da0000 {
> compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> reg = <0xda0000 0x10000>;
>
> @@ -1314,7 +1314,7 @@
> };
> };
>
> - adreno_smmu: arm,smmu@b40000 {
> + adreno_smmu: iommu@b40000 {
> compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> reg = <0xb40000 0x10000>;
>
> @@ -1331,7 +1331,7 @@
> power-domains = <&mmcc GPU_GDSC>;
> };
>
> - mdp_smmu: arm,smmu@d00000 {
> + mdp_smmu: iommu@d00000 {
> compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> reg = <0xd00000 0x10000>;
>
> @@ -1347,7 +1347,7 @@
> power-domains = <&mmcc MDSS_GDSC>;
> };
>
> - lpass_q6_smmu: arm,smmu-lpass_q6@1600000 {
> + lpass_q6_smmu: iommu@1600000 {
> compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> reg = <0x1600000 0x20000>;
> #iommu-cells = <1>;
> --
> 2.18.0
>


--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation