2020-08-17 14:50:46

by Frank Wunderlich

[permalink] [raw]
Subject: [BUG] 5.9-rc1 broken bootup on mt7622/mt7623

Hi

at least my Bananapi R2/R64 does not bootup (no output on serial console) with 5.9-rc1

made a bisect which points me to this commit:

commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36
Author: Saravana Kannan <[email protected]>
Date: Fri Jul 17 17:06:36 2020 -0700

irqchip/mtk-sysirq: Convert to a platform driver

This driver can work as a platform driver. So covert it to a platform
driver.

Signed-off-by: Saravana Kannan <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Reviewed-by: Hanks Chen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

drivers/irqchip/irq-mtk-sysirq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

at least on my devices i got 5.9 working by reverting the commit, will send a revert-Patch

$ git bisect log
git bisect start
# bad: [d24b5abc4640b46bb356bb5371d244866a5fe0a3] gitignore: add from 5.8 + itb/mod
git bisect bad d24b5abc4640b46bb356bb5371d244866a5fe0a3
# good: [bcf876870b95592b52519ed4aafcf9d95999bc9c] Linux 5.8
git bisect good bcf876870b95592b52519ed4aafcf9d95999bc9c
# bad: [8186749621ed6b8fc42644c399e8c755a2b6f630] Merge tag 'drm-next-2020-08-06' of git://anongit.freedesktop.org/drm/drm
git bisect bad 8186749621ed6b8fc42644c399e8c755a2b6f630
# bad: [2324d50d051ec0f14a548e78554fb02513d6dcef] Merge tag 'docs-5.9' of git://git.lwn.net/linux
git bisect bad 2324d50d051ec0f14a548e78554fb02513d6dcef
# good: [92c59e126b21fd212195358a0d296e787e444087] Merge tag 'arm-defconfig-5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
git bisect good 92c59e126b21fd212195358a0d296e787e444087
# good: [d4db4e553249eda9016fab2e363c26e52c47926f] Merge tag 'arm-newsoc-5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
git bisect good d4db4e553249eda9016fab2e363c26e52c47926f
# good: [fd76a74d940ae3d6b8b2395cd12914630c7e1739] Merge tag 'audit-pr-20200803' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit
git bisect good fd76a74d940ae3d6b8b2395cd12914630c7e1739
# bad: [95ffa676583b23baed40861d30b65fe31397da00] Merge branch 'parisc-5.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux
git bisect bad 95ffa676583b23baed40861d30b65fe31397da00
# bad: [f8b036a7fc231fe6e8297daddee5dffdbbf2581f] Merge tag 'irq-core-2020-08-04' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad f8b036a7fc231fe6e8297daddee5dffdbbf2581f
# good: [4f30a60aa78410496e5ffe632a371c00f0d83a8d] Merge tag 'close-range-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
git bisect good 4f30a60aa78410496e5ffe632a371c00f0d83a8d
# good: [8d16f5b979660c0fdcfa21a418cc03f1fde60cf7] genirq: Export irq_chip_retrigger_hierarchy and irq_chip_set_vcpu_affinity_parent
git bisect good 8d16f5b979660c0fdcfa21a418cc03f1fde60cf7
# bad: [c9c73a05413ea4a465cae1cb3593b01b190a233f] irqchip/loongson-liointc: Fix misuse of gc->mask_cache
git bisect bad c9c73a05413ea4a465cae1cb3593b01b190a233f
# bad: [f97dbf48ca43009e8b8bcdf07f47fc9f06149b36] irqchip/mtk-sysirq: Convert to a platform driver
git bisect bad f97dbf48ca43009e8b8bcdf07f47fc9f06149b36
# bad: [f97dbf48ca43009e8b8bcdf07f47fc9f06149b36] irqchip/mtk-sysirq: Convert to a platform driver
git bisect bad f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 //needs change from 762a21fd45e0 as build-fix
# good: [3af9571cd585efafc2facbd8dbd407317ff898cf] irqchip/gic-v4.1: Ensure accessing the correct RD when writing INVALLR
git bisect good 3af9571cd585efafc2facbd8dbd407317ff898cf
# good: [f8410e626569324cfe831aaecc0504cafc12b471] irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH helper macros
git bisect good f8410e626569324cfe831aaecc0504cafc12b471
# good: [5be57099d44550d2c4cf44a86c44df87edb79a57] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros
git bisect good 5be57099d44550d2c4cf44a86c44df87edb79a57
# first bad commit: [f97dbf48ca43009e8b8bcdf07f47fc9f06149b36] irqchip/mtk-sysirq: Convert to a platform driver

regards Frank


2020-08-17 14:58:25

by Enric Balletbo Serra

[permalink] [raw]
Subject: Re: [BUG] 5.9-rc1 broken bootup on mt7622/mt7623

Hi Frank,

Missatge de Frank Wunderlich <[email protected]> del dia dl., 17
d’ag. 2020 a les 16:48:
>
> Hi
>
> at least my Bananapi R2/R64 does not bootup (no output on serial console) with 5.9-rc1
>
> made a bisect which points me to this commit:
>
> commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36
> Author: Saravana Kannan <[email protected]>
> Date: Fri Jul 17 17:06:36 2020 -0700
>
> irqchip/mtk-sysirq: Convert to a platform driver
>
> This driver can work as a platform driver. So covert it to a platform
> driver.
>
> Signed-off-by: Saravana Kannan <[email protected]>
> Signed-off-by: Marc Zyngier <[email protected]>
> Reviewed-by: Hanks Chen <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]
>

Looks like all Mediatek devices are broken, you should try if this [1]
fixes the issue for you. It fixes for me.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=7828a3ef8646fb2e69ed45616c8453a037ca7867

Cheers,
Enric

> drivers/irqchip/irq-mtk-sysirq.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> at least on my devices i got 5.9 working by reverting the commit, will send a revert-Patch
>
> $ git bisect log
> git bisect start
> # bad: [d24b5abc4640b46bb356bb5371d244866a5fe0a3] gitignore: add from 5.8 + itb/mod
> git bisect bad d24b5abc4640b46bb356bb5371d244866a5fe0a3
> # good: [bcf876870b95592b52519ed4aafcf9d95999bc9c] Linux 5.8
> git bisect good bcf876870b95592b52519ed4aafcf9d95999bc9c
> # bad: [8186749621ed6b8fc42644c399e8c755a2b6f630] Merge tag 'drm-next-2020-08-06' of git://anongit.freedesktop.org/drm/drm
> git bisect bad 8186749621ed6b8fc42644c399e8c755a2b6f630
> # bad: [2324d50d051ec0f14a548e78554fb02513d6dcef] Merge tag 'docs-5.9' of git://git.lwn.net/linux
> git bisect bad 2324d50d051ec0f14a548e78554fb02513d6dcef
> # good: [92c59e126b21fd212195358a0d296e787e444087] Merge tag 'arm-defconfig-5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
> git bisect good 92c59e126b21fd212195358a0d296e787e444087
> # good: [d4db4e553249eda9016fab2e363c26e52c47926f] Merge tag 'arm-newsoc-5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
> git bisect good d4db4e553249eda9016fab2e363c26e52c47926f
> # good: [fd76a74d940ae3d6b8b2395cd12914630c7e1739] Merge tag 'audit-pr-20200803' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit
> git bisect good fd76a74d940ae3d6b8b2395cd12914630c7e1739
> # bad: [95ffa676583b23baed40861d30b65fe31397da00] Merge branch 'parisc-5.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux
> git bisect bad 95ffa676583b23baed40861d30b65fe31397da00
> # bad: [f8b036a7fc231fe6e8297daddee5dffdbbf2581f] Merge tag 'irq-core-2020-08-04' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
> git bisect bad f8b036a7fc231fe6e8297daddee5dffdbbf2581f
> # good: [4f30a60aa78410496e5ffe632a371c00f0d83a8d] Merge tag 'close-range-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
> git bisect good 4f30a60aa78410496e5ffe632a371c00f0d83a8d
> # good: [8d16f5b979660c0fdcfa21a418cc03f1fde60cf7] genirq: Export irq_chip_retrigger_hierarchy and irq_chip_set_vcpu_affinity_parent
> git bisect good 8d16f5b979660c0fdcfa21a418cc03f1fde60cf7
> # bad: [c9c73a05413ea4a465cae1cb3593b01b190a233f] irqchip/loongson-liointc: Fix misuse of gc->mask_cache
> git bisect bad c9c73a05413ea4a465cae1cb3593b01b190a233f
> # bad: [f97dbf48ca43009e8b8bcdf07f47fc9f06149b36] irqchip/mtk-sysirq: Convert to a platform driver
> git bisect bad f97dbf48ca43009e8b8bcdf07f47fc9f06149b36
> # bad: [f97dbf48ca43009e8b8bcdf07f47fc9f06149b36] irqchip/mtk-sysirq: Convert to a platform driver
> git bisect bad f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 //needs change from 762a21fd45e0 as build-fix
> # good: [3af9571cd585efafc2facbd8dbd407317ff898cf] irqchip/gic-v4.1: Ensure accessing the correct RD when writing INVALLR
> git bisect good 3af9571cd585efafc2facbd8dbd407317ff898cf
> # good: [f8410e626569324cfe831aaecc0504cafc12b471] irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH helper macros
> git bisect good f8410e626569324cfe831aaecc0504cafc12b471
> # good: [5be57099d44550d2c4cf44a86c44df87edb79a57] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros
> git bisect good 5be57099d44550d2c4cf44a86c44df87edb79a57
> # first bad commit: [f97dbf48ca43009e8b8bcdf07f47fc9f06149b36] irqchip/mtk-sysirq: Convert to a platform driver
>
> regards Frank
>

2020-08-17 21:26:25

by Frank Wunderlich

[permalink] [raw]
Subject: Aw: Re: [BUG] 5.9-rc1 broken bootup on mt7622/mt7623

Hi Enric

> Gesendet: Montag, 17. August 2020 um 16:56 Uhr
> Von: "Enric Balletbo Serra" <[email protected]>
> Looks like all Mediatek devices are broken, you should try if this [1]
> fixes the issue for you. It fixes for me.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=7828a3ef8646fb2e69ed45616c8453a037ca7867

This seems to fix the issue on my 2 devices too

Thank you

regards Frank