2019-03-04 17:18:23

by Andrey Konovalov

Subject: [PATCH] kasan: fix coccinelle warnings in kasan_p*_table

kasan_p4d_table, kasan_pmd_table and kasan_pud_table are declared as
returning bool, but return 0 instead of false, which produces a coccinelle
warning. Fix it.

Fixes: 0207df4fa1a8 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Andrey Konovalov <[email protected]>
---
mm/kasan/init.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/kasan/init.c b/mm/kasan/init.c
index 45a1b5e38e1e..fcaa1ca03175 100644
--- a/mm/kasan/init.c
+++ b/mm/kasan/init.c
@@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd)
#else
static inline bool kasan_p4d_table(pgd_t pgd)
{
- return 0;
+ return false;
}
#endif
#if CONFIG_PGTABLE_LEVELS > 3
@@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d)
#else
static inline bool kasan_pud_table(p4d_t p4d)
{
- return 0;
+ return false;
}
#endif
#if CONFIG_PGTABLE_LEVELS > 2
@@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud)
#else
static inline bool kasan_pmd_table(pud_t pud)
{
- return 0;
+ return false;
}
#endif
pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss;
--
2.21.0.352.gf09ad66450-goog

2019-03-05 16:15:43

by Andrey Ryabinin

Subject: Re: [PATCH] kasan: fix coccinelle warnings in kasan_p*_table

On 3/4/19 8:04 PM, Andrey Konovalov wrote:
> kasan_p4d_table, kasan_pmd_table and kasan_pud_table are declared as
> returning bool, but return 0 instead of false, which produces a coccinelle
> warning. Fix it.
>
> Fixes: 0207df4fa1a8 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN")
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Andrey Konovalov <[email protected]>
> ---

Acked-by: Andrey Ryabinin <[email protected]>


> mm/kasan/init.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> index 45a1b5e38e1e..fcaa1ca03175 100644
> --- a/mm/kasan/init.c
> +++ b/mm/kasan/init.c
> @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd)
> #else
> static inline bool kasan_p4d_table(pgd_t pgd)
> {
> - return 0;
> + return false;
> }
> #endif
> #if CONFIG_PGTABLE_LEVELS > 3
> @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d)
> #else
> static inline bool kasan_pud_table(p4d_t p4d)
> {
> - return 0;
> + return false;
> }
> #endif
> #if CONFIG_PGTABLE_LEVELS > 2
> @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud)
> #else
> static inline bool kasan_pmd_table(pud_t pud)
> {
> - return 0;
> + return false;
> }
> #endif
> pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss;
>

2019-03-08 03:04:20

by Souptick Joarder

Subject: Re: [PATCH] kasan: fix coccinelle warnings in kasan_p*_table

On Tue, Mar 5, 2019 at 9:43 PM Andrey Ryabinin <[email protected]> wrote:
>
>
>
> On 3/4/19 8:04 PM, Andrey Konovalov wrote:
> > kasan_p4d_table, kasan_pmd_table and kasan_pud_table are declared as
> > returning bool, but return 0 instead of false, which produces a coccinelle
> > warning. Fix it.
> >
> > Fixes: 0207df4fa1a8 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN")
> > Reported-by: kbuild test robot <[email protected]>
> > Signed-off-by: Andrey Konovalov <[email protected]>
> > ---
>
> Acked-by: Andrey Ryabinin <[email protected]>
>
>
> > mm/kasan/init.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> > index 45a1b5e38e1e..fcaa1ca03175 100644
> > --- a/mm/kasan/init.c
> > +++ b/mm/kasan/init.c
> > @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd)
> > #else
> > static inline bool kasan_p4d_table(pgd_t pgd)
> > {
> > - return 0;
> > + return false;
> > }
> > #endif
> > #if CONFIG_PGTABLE_LEVELS > 3
> > @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d)
> > #else
> > static inline bool kasan_pud_table(p4d_t p4d)
> > {
> > - return 0;
> > + return false;
> > }
> > #endif
> > #if CONFIG_PGTABLE_LEVELS > 2
> > @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud)
> > #else
> > static inline bool kasan_pmd_table(pud_t pud)
> > {
> > - return 0;
> > + return false;
> > }
> > #endif
> > pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss;
> >
>

Acked-by: Souptick Joarder <[email protected]>