2019-03-04 18:45:33

by Souptick Joarder

[permalink] [raw]
Subject: [PATCH] selftest/proc: Remove duplicate header

Remove duplicate header which is included twice.

Signed-off-by: Sabyasachi Gupta <[email protected]>
Signed-off-by: Souptick Joarder <[email protected]>
---
tools/testing/selftests/proc/proc-self-syscall.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/proc/proc-self-syscall.c b/tools/testing/selftests/proc/proc-self-syscall.c
index 5ab5f48..3a4fec3 100644
--- a/tools/testing/selftests/proc/proc-self-syscall.c
+++ b/tools/testing/selftests/proc/proc-self-syscall.c
@@ -20,7 +20,6 @@
#include <sys/stat.h>
#include <fcntl.h>
#include <errno.h>
-#include <unistd.h>
#include <string.h>
#include <stdio.h>

--
1.9.1



2019-03-05 00:39:31

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] selftest/proc: Remove duplicate header

On Mon, 4 Mar 2019 23:57:19 +0530 Souptick Joarder <[email protected]> wrote:

> Remove duplicate header which is included twice.
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>
> Signed-off-by: Souptick Joarder <[email protected]>

This signoff order makes me suspect that Sabyasachi was the author. If
so, the patch should have had Sabyasachi's From: line at the start of
the changelog.

Please clafify?


2019-03-05 04:53:10

by Souptick Joarder

[permalink] [raw]
Subject: Re: [PATCH] selftest/proc: Remove duplicate header

On Tue, Mar 5, 2019 at 6:07 AM Andrew Morton <[email protected]> wrote:
>
> On Mon, 4 Mar 2019 23:57:19 +0530 Souptick Joarder <[email protected]> wrote:
>
> > Remove duplicate header which is included twice.
> >
> > Signed-off-by: Sabyasachi Gupta <[email protected]>
> > Signed-off-by: Souptick Joarder <[email protected]>
>
> This signoff order makes me suspect that Sabyasachi was the author. If
> so, the patch should have had Sabyasachi's From: line at the start of
> the changelog.
>
> Please clafify?

yes, sabyasachi was the author, but due to some email client issue
I am posting on behalf of him.
Ok, I will add Sabyasachi's From: line and post v2.