2020-11-24 19:51:01

by kernel test robot

[permalink] [raw]
Subject: arch/powerpc/platforms/pseries/reconfig.c:394:30: error: 'ofdt_proc_ops' defined but not used

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d5beb3140f91b1c8a3d41b14d729aefa4dcc58bc
commit: 97a32539b9568bb653683349e5a76d02ff3c3e2c proc: convert everything to "struct proc_ops"
date: 10 months ago
config: powerpc-randconfig-r002-20201124 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=97a32539b9568bb653683349e5a76d02ff3c3e2c
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 97a32539b9568bb653683349e5a76d02ff3c3e2c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

>> arch/powerpc/platforms/pseries/reconfig.c:394:30: error: 'ofdt_proc_ops' defined but not used [-Werror=unused-const-variable=]
394 | static const struct proc_ops ofdt_proc_ops = {
| ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
>> arch/powerpc/platforms/pseries/lparcfg.c:701:30: error: 'lparcfg_proc_ops' defined but not used [-Werror=unused-const-variable=]
701 | static const struct proc_ops lparcfg_proc_ops = {
| ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

vim +/ofdt_proc_ops +394 arch/powerpc/platforms/pseries/reconfig.c

393
> 394 static const struct proc_ops ofdt_proc_ops = {
395 .proc_write = ofdt_write,
396 .proc_lseek = noop_llseek,
397 };
398

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (2.06 kB)
.config.gz (27.11 kB)
Download all attachments

2020-11-25 22:29:57

by Souptick Joarder

[permalink] [raw]
Subject: Re: arch/powerpc/platforms/pseries/reconfig.c:394:30: error: 'ofdt_proc_ops' defined but not used

On Tue, Nov 24, 2020 at 12:40 PM kernel test robot <[email protected]> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: d5beb3140f91b1c8a3d41b14d729aefa4dcc58bc
> commit: 97a32539b9568bb653683349e5a76d02ff3c3e2c proc: convert everything to "struct proc_ops"
> date: 10 months ago
> config: powerpc-randconfig-r002-20201124 (attached as .config)
> compiler: powerpc64le-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=97a32539b9568bb653683349e5a76d02ff3c3e2c
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 97a32539b9568bb653683349e5a76d02ff3c3e2c
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> >> arch/powerpc/platforms/pseries/reconfig.c:394:30: error: 'ofdt_proc_ops' defined but not used [-Werror=unused-const-variable=]
> 394 | static const struct proc_ops ofdt_proc_ops = {
> | ^~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> --
> >> arch/powerpc/platforms/pseries/lparcfg.c:701:30: error: 'lparcfg_proc_ops' defined but not used [-Werror=unused-const-variable=]
> 701 | static const struct proc_ops lparcfg_proc_ops = {
> | ^~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Both ofdt_proc_ops & lparcfg_proc_ops are used by proc_create().
Not sure why it is throwing warnings.

>
> vim +/ofdt_proc_ops +394 arch/powerpc/platforms/pseries/reconfig.c
>
> 393
> > 394 static const struct proc_ops ofdt_proc_ops = {
> 395 .proc_write = ofdt_write,
> 396 .proc_lseek = noop_llseek,
> 397 };
> 398
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/[email protected]

2020-11-25 22:30:28

by Randy Dunlap

[permalink] [raw]
Subject: Re: arch/powerpc/platforms/pseries/reconfig.c:394:30: error: 'ofdt_proc_ops' defined but not used

On 11/25/20 11:13 AM, Souptick Joarder wrote:
> On Tue, Nov 24, 2020 at 12:40 PM kernel test robot <[email protected]> wrote:
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: d5beb3140f91b1c8a3d41b14d729aefa4dcc58bc
>> commit: 97a32539b9568bb653683349e5a76d02ff3c3e2c proc: convert everything to "struct proc_ops"
>> date: 10 months ago
>> config: powerpc-randconfig-r002-20201124 (attached as .config)
>> compiler: powerpc64le-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=97a32539b9568bb653683349e5a76d02ff3c3e2c
>> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> git fetch --no-tags linus master
>> git checkout 97a32539b9568bb653683349e5a76d02ff3c3e2c
>> # save the attached .config to linux build tree
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <[email protected]>
>>
>> All errors (new ones prefixed by >>):
>>
>>>> arch/powerpc/platforms/pseries/reconfig.c:394:30: error: 'ofdt_proc_ops' defined but not used [-Werror=unused-const-variable=]
>> 394 | static const struct proc_ops ofdt_proc_ops = {
>> | ^~~~~~~~~~~~~
>> cc1: all warnings being treated as errors
>> --
>>>> arch/powerpc/platforms/pseries/lparcfg.c:701:30: error: 'lparcfg_proc_ops' defined but not used [-Werror=unused-const-variable=]
>> 701 | static const struct proc_ops lparcfg_proc_ops = {
>> | ^~~~~~~~~~~~~~~~
>> cc1: all warnings being treated as errors
>
> Both ofdt_proc_ops & lparcfg_proc_ops are used by proc_create().
> Not sure why it is throwing warnings.
>

because this:

# CONFIG_PROC_FS is not set

>>
>> vim +/ofdt_proc_ops +394 arch/powerpc/platforms/pseries/reconfig.c
>>
>> 393
>> > 394 static const struct proc_ops ofdt_proc_ops = {
>> 395 .proc_write = ofdt_write,
>> 396 .proc_lseek = noop_llseek,
>> 397 };
>> 398


--
~Randy