Remove duplicate header which is included twice
Signed-off-by: Sabyasachi Gupta <[email protected]>
Signed-off-by: Souptick Joarder <[email protected]>
---
tools/testing/selftests/rseq/rseq.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/rseq/rseq.h b/tools/testing/selftests/rseq/rseq.h
index c72eb70..6c1126e7 100644
--- a/tools/testing/selftests/rseq/rseq.h
+++ b/tools/testing/selftests/rseq/rseq.h
@@ -16,7 +16,6 @@
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
-#include <sched.h>
#include <linux/rseq.h>
/*
--
1.9.1
----- On Mar 4, 2019, at 1:38 PM, Souptick Joarder [email protected] wrote:
> Remove duplicate header which is included twice
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>
> Signed-off-by: Souptick Joarder <[email protected]>
Acked-by: Mathieu Desnoyers <[email protected]>
> ---
> tools/testing/selftests/rseq/rseq.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/rseq/rseq.h
> b/tools/testing/selftests/rseq/rseq.h
> index c72eb70..6c1126e7 100644
> --- a/tools/testing/selftests/rseq/rseq.h
> +++ b/tools/testing/selftests/rseq/rseq.h
> @@ -16,7 +16,6 @@
> #include <errno.h>
> #include <stdio.h>
> #include <stdlib.h>
> -#include <sched.h>
> #include <linux/rseq.h>
>
> /*
> --
> 1.9.1
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote:
> Remove duplicate header which is included twice
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>
> Signed-off-by: Souptick Joarder <[email protected]>
That SoB chain is invalid.
On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <[email protected]> wrote:
>
> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote:
> > Remove duplicate header which is included twice
> >
> > Signed-off-by: Sabyasachi Gupta <[email protected]>
> > Signed-off-by: Souptick Joarder <[email protected]>
>
> That SoB chain is invalid.
I didn't get why it is invalid ?
----- On Mar 4, 2019, at 1:53 PM, Souptick Joarder [email protected] wrote:
> On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <[email protected]> wrote:
>>
>> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote:
>> > Remove duplicate header which is included twice
>> >
>> > Signed-off-by: Sabyasachi Gupta <[email protected]>
>> > Signed-off-by: Souptick Joarder <[email protected]>
>>
>> That SoB chain is invalid.
>
> I didn't get why it is invalid ?
I think it's about having the author of the patch (From) as first
Signed-off-by, and then apply following Signed-off-by by maintainers
who pick up the patch. (That's what I am used to see)
What is the intent behind the second Signed-off-by by Sabyasachi Gupta ?
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
On Tue, Mar 5, 2019 at 1:27 AM Mathieu Desnoyers
<[email protected]> wrote:
>
> ----- On Mar 4, 2019, at 1:53 PM, Souptick Joarder [email protected] wrote:
>
> > On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <[email protected]> wrote:
> >>
> >> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote:
> >> > Remove duplicate header which is included twice
> >> >
> >> > Signed-off-by: Sabyasachi Gupta <[email protected]>
> >> > Signed-off-by: Souptick Joarder <[email protected]>
> >>
> >> That SoB chain is invalid.
> >
> > I didn't get why it is invalid ?
>
> I think it's about having the author of the patch (From) as first
> Signed-off-by, and then apply following Signed-off-by by maintainers
> who pick up the patch. (That's what I am used to see)
>
> What is the intent behind the second Signed-off-by by Sabyasachi Gupta ?
Sabyasachi is the author and I am posting his patches as his email client
has some issue. I think I need to add Sabyasachi's From: @ the
beginning of change log.
Andrew suggested the same in another thread.
>
> Thanks,
>
> Mathieu
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com