2022-02-18 00:08:34

by Souptick Joarder

Subject: [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()

From: "Souptick Joarder (HPE)" <[email protected]>

Kernel test robot throws warning ->
arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
for function 'iop_enable_cp6' [-Wmissing-prototypes]

Adding prototype by including header.

Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder (HPE) <[email protected]>
---
arch/arm/mach-iop32x/cp6.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-iop32x/cp6.c b/arch/arm/mach-iop32x/cp6.c
index 2882674a1c39..7135a0ac9949 100644
--- a/arch/arm/mach-iop32x/cp6.c
+++ b/arch/arm/mach-iop32x/cp6.c
@@ -7,6 +7,8 @@
#include <asm/traps.h>
#include <asm/ptrace.h>

+#include "iop3xx.h"
+
void iop_enable_cp6(void)
{
u32 temp;
--
2.25.1

2022-03-01 03:37:21

by Souptick Joarder

Subject: Re: [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()

On Fri, Feb 18, 2022 at 4:17 AM Souptick Joarder <[email protected]> wrote:
>
> From: "Souptick Joarder (HPE)" <[email protected]>
>
> Kernel test robot throws warning ->
> arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
> for function 'iop_enable_cp6' [-Wmissing-prototypes]
>
> Adding prototype by including header.

Any comments on this patch ?

>
> Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder (HPE) <[email protected]>
> ---
> arch/arm/mach-iop32x/cp6.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-iop32x/cp6.c b/arch/arm/mach-iop32x/cp6.c
> index 2882674a1c39..7135a0ac9949 100644
> --- a/arch/arm/mach-iop32x/cp6.c
> +++ b/arch/arm/mach-iop32x/cp6.c
> @@ -7,6 +7,8 @@
> #include <asm/traps.h>
> #include <asm/ptrace.h>
>
> +#include "iop3xx.h"
> +
> void iop_enable_cp6(void)
> {
> u32 temp;
> --
> 2.25.1
>

2022-03-01 10:54:42

by Arnd Bergmann

Subject: Re: [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()

On Thu, Feb 17, 2022 at 11:46 PM Souptick Joarder <[email protected]> wrote:
>
> From: "Souptick Joarder (HPE)" <[email protected]>
>
> Kernel test robot throws warning ->
> arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
> for function 'iop_enable_cp6' [-Wmissing-prototypes]
>
> Adding prototype by including header.

It may be worth mentioning that this only happens with W=1 or V=1 but
not with the
normal build options.

> Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder (HPE) <[email protected]>

Reviewed-by: Arnd Bergmann <[email protected]>

Russell, please apply this on top of the arm-vmap-stacks-v6 that contains my
original patch withthe W=1 warning.

Arnd