2018-12-21 18:15:48

by Brajeswar Ghosh

Subject: [PATCH] drm/amd/powerplay: Remove duplicate header

Remove hwmgr_ppt.h which is included more than once

Signed-off-by: Brajeswar Ghosh <[email protected]>
---
drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
index e5a60aa44b5d..07d180ce4d18 100644
--- a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
+++ b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
@@ -28,7 +28,6 @@
#include "hardwaremanager.h"
#include "hwmgr_ppt.h"
#include "ppatomctrl.h"
-#include "hwmgr_ppt.h"
#include "power_state.h"
#include "smu_helper.h"

--
2.17.1

2018-12-21 16:42:42

by Souptick Joarder

Subject: Re: [PATCH] drm/amd/powerplay: Remove duplicate header

On Fri, Dec 21, 2018 at 2:49 PM Brajeswar Ghosh
<[email protected]> wrote:
>
> Remove hwmgr_ppt.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh <[email protected]>
> ---
Acked-by: Souptick Joarder <[email protected]>

> drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> index e5a60aa44b5d..07d180ce4d18 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> @@ -28,7 +28,6 @@
> #include "hardwaremanager.h"
> #include "hwmgr_ppt.h"
> #include "ppatomctrl.h"
> -#include "hwmgr_ppt.h"
> #include "power_state.h"
> #include "smu_helper.h"
>
> --
> 2.17.1
>

2019-01-30 13:59:47

by Brajeswar Ghosh

Subject: Re: [PATCH] drm/amd/powerplay: Remove duplicate header

On Fri, Dec 21, 2018 at 6:06 PM Souptick Joarder <[email protected]> wrote:
>
> On Fri, Dec 21, 2018 at 2:49 PM Brajeswar Ghosh
> <[email protected]> wrote:
> >
> > Remove hwmgr_ppt.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <[email protected]>
> > ---
> Acked-by: Souptick Joarder <[email protected]>

If no further comment, can we get this patch in queue for 5.1 ?

>
> > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> > index e5a60aa44b5d..07d180ce4d18 100644
> > --- a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> > +++ b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> > @@ -28,7 +28,6 @@
> > #include "hardwaremanager.h"
> > #include "hwmgr_ppt.h"
> > #include "ppatomctrl.h"
> > -#include "hwmgr_ppt.h"
> > #include "power_state.h"
> > #include "smu_helper.h"
> >
> > --
> > 2.17.1
> >