2023-09-28 04:58:16

by Mehdi Djait

[permalink] [raw]
Subject: Re: [PATCH 0/2] Support ROHM KX132ACR-LBZ Accelerometer

Hello Matti,

On Wed, Sep 27, 2023 at 2:56 PM Matti Vaittinen
<[email protected]> wrote:
>
> The ROHM KX132ACR-LBZ is an accelerometer for industrial applications.
> It has a subset of KX022A (NOTE: Not KX132-1211) functionalities, dropping
> support for tap, free fall and tilt detection engines. Also, the register
> interface is an exact subset of what is found on KX022A (except the
> WHO_AM_I register value).
>
> This series adds own DT compatible for the KX132ACR-LBZ and also own
> chip-info in driver to allow handling the different 'WHO_AM_I' value.
> The separation of the Kionix KX022A and ROHM KX132ACR-LBZ does also
> allow adding support for the KX022A tilt/free fall/tap engines which are
> not present on KX132ACR-LBZ.
>
> Matti Vaittinen (2):
> dt-bindings: iio: Add KX132ACR-LBZ accelerometer
> iio: kx022a: Support ROHM KX132ACR-LBZ
>
> .../bindings/iio/accel/kionix,kx022a.yaml | 10 +++---
> drivers/iio/accel/kionix-kx022a-i2c.c | 4 ++-
> drivers/iio/accel/kionix-kx022a-spi.c | 4 ++-
> drivers/iio/accel/kionix-kx022a.c | 34 ++++++++++++++++++-
> drivers/iio/accel/kionix-kx022a.h | 2 ++
> 5 files changed, 47 insertions(+), 7 deletions(-)
>

You could also mention this device in the list of supported devices
under drivers/iio/accel/Kconfig

--
Kind Regards
Mehdi Djait


2023-09-28 06:07:34

by Matti Vaittinen

[permalink] [raw]
Subject: Re: [PATCH 0/2] Support ROHM KX132ACR-LBZ Accelerometer

On 9/27/23 17:30, Mehdi Djait wrote:
> Hello Matti,
>
> On Wed, Sep 27, 2023 at 2:56 PM Matti Vaittinen
> <[email protected]> wrote:
>>
>> The ROHM KX132ACR-LBZ is an accelerometer for industrial applications.
>> It has a subset of KX022A (NOTE: Not KX132-1211) functionalities, dropping
>> support for tap, free fall and tilt detection engines. Also, the register
>> interface is an exact subset of what is found on KX022A (except the
>> WHO_AM_I register value).
>>
>> This series adds own DT compatible for the KX132ACR-LBZ and also own
>> chip-info in driver to allow handling the different 'WHO_AM_I' value.
>> The separation of the Kionix KX022A and ROHM KX132ACR-LBZ does also
>> allow adding support for the KX022A tilt/free fall/tap engines which are
>> not present on KX132ACR-LBZ.
>>
>> Matti Vaittinen (2):
>> dt-bindings: iio: Add KX132ACR-LBZ accelerometer
>> iio: kx022a: Support ROHM KX132ACR-LBZ
>>
>> .../bindings/iio/accel/kionix,kx022a.yaml | 10 +++---
>> drivers/iio/accel/kionix-kx022a-i2c.c | 4 ++-
>> drivers/iio/accel/kionix-kx022a-spi.c | 4 ++-
>> drivers/iio/accel/kionix-kx022a.c | 34 ++++++++++++++++++-
>> drivers/iio/accel/kionix-kx022a.h | 2 ++
>> 5 files changed, 47 insertions(+), 7 deletions(-)
>>
>
> You could also mention this device in the list of supported devices
> under drivers/iio/accel/Kconfig

Oh, indeed. Thanks Mehdi!

Yours,
-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~