2013-09-06 11:43:41

by Tom Gundersen

Subject: [PATCH] simplefb: print some info about the registered fb

This is similar to the output printed by efifb.

Signed-off-by: Tom Gundersen <[email protected]>
Cc: Stephen Warren <[email protected]>
Cc: David Herrmann <[email protected]>
---
drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
index 8d78106..4196686 100644
--- a/drivers/video/simplefb.c
+++ b/drivers/video/simplefb.c
@@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)
}
info->pseudo_palette = (void *)(info + 1);

+ dev_info(&pdev->dev, "framebuffer at 0x%lx, mapped to 0x%p\n",
+ info->fix.smem_start, info->screen_base);
+ dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",
+ params.format->name,
+ info->var.xres, info->var.yres,
+ info->var.bits_per_pixel,
+ info->fix.line_length);
+
ret = register_framebuffer(info);
if (ret < 0) {
dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret);
--
1.8.4

2013-09-06 11:48:10

by Tom Gundersen

Subject: [PATCH] simplefb: print some info about the registered fb

This is similar to the output printed by efifb.

Signed-off-by: Tom Gundersen <[email protected]>
Cc: Stephen Warren <[email protected]>
Cc: David Herrmann <[email protected]>
---

Hi,

Sorry for the resend, got the ml address wrong.

-t

drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
index 8d78106..4196686 100644
--- a/drivers/video/simplefb.c
+++ b/drivers/video/simplefb.c
@@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)
}
info->pseudo_palette = (void *)(info + 1);

+ dev_info(&pdev->dev, "framebuffer at 0x%lx, mapped to 0x%p\n",
+ info->fix.smem_start, info->screen_base);
+ dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",
+ params.format->name,
+ info->var.xres, info->var.yres,
+ info->var.bits_per_pixel,
+ info->fix.line_length);
+
ret = register_framebuffer(info);
if (ret < 0) {
dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret);
--
1.8.4

2013-09-06 19:11:08

by Stephen Warren

Subject: Re: [PATCH] simplefb: print some info about the registered fb

On 09/06/2013 05:49 AM, Tom Gundersen wrote:
> This is similar to the output printed by efifb.

Fine by me,
Acked-by: Stephen Warren <[email protected]>

2013-09-07 11:16:25

by David Herrmann

Subject: Re: [PATCH] simplefb: print some info about the registered fb

Hi Tom

On Fri, Sep 6, 2013 at 1:49 PM, Tom Gundersen <[email protected]> wrote:
> This is similar to the output printed by efifb.
>
> Signed-off-by: Tom Gundersen <[email protected]>
> Cc: Stephen Warren <[email protected]>
> Cc: David Herrmann <[email protected]>
> ---
>
> Hi,
>
> Sorry for the resend, got the ml address wrong.
>
> -t
>
> drivers/video/simplefb.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
> index 8d78106..4196686 100644
> --- a/drivers/video/simplefb.c
> +++ b/drivers/video/simplefb.c
> @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)
> }
> info->pseudo_palette = (void *)(info + 1);
>
> + dev_info(&pdev->dev, "framebuffer at 0x%lx, mapped to 0x%p\n",
> + info->fix.smem_start, info->screen_base);

Could we get smem_len, too? Something like:
dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped
to 0x%p\n",
info->fix.smem_start, (unsigned
long)info->fix.smem_len, info->screen_base);

(smem_len is __u32, so cast it to avoid truncation if it's defined as
long somewhere. Not sure whether we actually have 16bit int somewhere,
though)

Cheers
David

> + dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",
> + params.format->name,
> + info->var.xres, info->var.yres,
> + info->var.bits_per_pixel,
> + info->fix.line_length);
> +
> ret = register_framebuffer(info);
> if (ret < 0) {
> dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret);
> --
> 1.8.4
>

2013-09-07 11:42:37

by Tom Gundersen

Subject: [PATCH v2] simplefb: print some info about the registered fb

This is similar to the output printed by efifb.

Signed-off-by: Tom Gundersen <[email protected]>
Acked-by: Stephen Warren <[email protected]>
Cc: David Herrmann <[email protected]>
---

v2: also print smem_len as requested by David

drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
index 8d78106..80cf074 100644
--- a/drivers/video/simplefb.c
+++ b/drivers/video/simplefb.c
@@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)
}
info->pseudo_palette = (void *)(info + 1);

+ dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped to 0x%p\n",
+ info->fix.smem_start, (unsigned long) info->fix.smem_len,
+ info->screen_base);
+ dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",
+ params.format->name,
+ info->var.xres, info->var.yres,
+ info->var.bits_per_pixel, info->fix.line_length);
+
ret = register_framebuffer(info);
if (ret < 0) {
dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret);
--
1.8.4

2013-09-07 13:55:40

by Geert Uytterhoeven

Subject: Re: [PATCH v2] simplefb: print some info about the registered fb

On Sat, Sep 7, 2013 at 1:43 PM, Tom Gundersen <[email protected]> wrote:
> + dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped to 0x%p\n",
> + info->fix.smem_start, (unsigned long) info->fix.smem_len,

Please drop the cast, and use 0x%x. __u32 is unsigned int everywhere (where it
matters --- we don't do 16-bit ints).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2013-09-07 14:07:34

by Tom Gundersen

Subject: [PATCH v3] simplefb: print some info about the registered fb

This is similar to the output printed by efifb.

Signed-off-by: Tom Gundersen <[email protected]>
Acked-by: Stephen Warren <[email protected]>
Cc: David Herrmann <[email protected]>
---
v2: also print smem_len, as requested by David
v3: don't cast, as requested by Geert

drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
index a29f1c4..50cbceb 100644
--- a/drivers/video/simplefb.c
+++ b/drivers/video/simplefb.c
@@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)
}
info->pseudo_palette = (void *)(info + 1);

+ dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n",
+ info->fix.smem_start, info->fix.smem_len,
+ info->screen_base);
+ dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",
+ params.format->name,
+ info->var.xres, info->var.yres,
+ info->var.bits_per_pixel, info->fix.line_length);
+
ret = register_framebuffer(info);
if (ret < 0) {
dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret);
--
1.8.4

2013-10-01 16:45:38

by Tom Gundersen

Subject: Re: [PATCH v3] simplefb: print some info about the registered fb

On Sat, Sep 7, 2013 at 4:08 PM, Tom Gundersen <[email protected]> wrote:
> This is similar to the output printed by efifb.
>
> Signed-off-by: Tom Gundersen <[email protected]>
> Acked-by: Stephen Warren <[email protected]>
> Cc: David Herrmann <[email protected]>
> ---
> v2: also print smem_len, as requested by David
> v3: don't cast, as requested by Geert

Jean-Christophe and Tomi,

What's the status of this, did either of you pick it up for 3.12 or 3.13?

Cheers,

Tom

2013-10-09 09:06:06

by Tomi Valkeinen

Subject: Re: [PATCH v3] simplefb: print some info about the registered fb

On 07/09/13 17:08, Tom Gundersen wrote:
> This is similar to the output printed by efifb.
>
> Signed-off-by: Tom Gundersen <[email protected]>
> Acked-by: Stephen Warren <[email protected]>
> Cc: David Herrmann <[email protected]>
> ---
> v2: also print smem_len, as requested by David
> v3: don't cast, as requested by Geert
>
> drivers/video/simplefb.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
> index a29f1c4..50cbceb 100644
> --- a/drivers/video/simplefb.c
> +++ b/drivers/video/simplefb.c
> @@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)
> }
> info->pseudo_palette = (void *)(info + 1);
>
> + dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%x bytes, mapped to 0x%p\n",
> + info->fix.smem_start, info->fix.smem_len,
> + info->screen_base);
> + dev_info(&pdev->dev, "format=%s, mode=%dx%dx%d, linelength=%d\n",
> + params.format->name,
> + info->var.xres, info->var.yres,
> + info->var.bits_per_pixel, info->fix.line_length);
> +
> ret = register_framebuffer(info);
> if (ret < 0) {
> dev_err(&pdev->dev, "Unable to register simplefb: %d\n", ret);
>

Thanks, queued for 3.13.

Tomi

Attachments: