2014-06-09 13:45:40

by B_B_Singh

[permalink] [raw]
Subject: [PATCH] firmware loader: allow disabling of udev as firmware loader


Hi All,

The existing BIOS-DUP's will not work on latest kernel, which has CONFIG_FW_LOADER_USER_HELPER=n ?configured in Kernel config by default which is not expected by the dell_rbu.

We have made a changes in BIOS-Dell Update Package so that BIOS-DUP will pick the payload from the /lib/firmware/ path & update the BIOS even when CONFIG_FW_LOADER_USER_HELPER=n is configured .

We have tested this patch http://www.spinics.net/lists/kernel/msg1755247.html?with latest BIOS Dell Update Package?(which has new implementation for the BIOS update i.e, copying the BIOS payload in /lib/firmware path & dell_rbu picks the payload from the same path) ?& with ?stable upstream ?????kernel-3.14.5 & we don't see any negative effects/errors for dell_rbu.

All the Test results are positive.

Regards
Balaji Singh


2014-06-09 13:53:36

by Tom Gundersen

[permalink] [raw]
Subject: Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

Hi Balaji,

On Mon, Jun 9, 2014 at 3:26 PM, <[email protected]> wrote:
> The existing BIOS-DUP’s will not work on latest kernel, which has
> CONFIG_FW_LOADER_USER_HELPER=n configured in Kernel config by default which
> is not expected by the dell_rbu.
>
>
>
> We have made a changes in BIOS-Dell Update Package so that BIOS-DUP will
> pick the payload from the /lib/firmware/ path & update the BIOS even when
> CONFIG_FW_LOADER_USER_HELPER=n is configured .
>
>
>
> We have tested this patch
> http://www.spinics.net/lists/kernel/msg1755247.html with latest BIOS Dell
> Update Package (which has new implementation for the BIOS update i.e,
> copying the BIOS payload in /lib/firmware path & dell_rbu picks the payload
> from the same path) & with stable upstream kernel-3.14.5 & we don’t
> see any negative effects/errors for dell_rbu.

Thanks for testing! May I ask if the dell_rbu still works with my
patch and CONFIG_FW_LOADER_USER_HELPER=n with the old userspace? The
intention was that you should not need to change anything in userspace
at all.

By the way, there is now a new version of this patch:
<https://lkml.org/lkml/2014/6/4/327>, which should allow your (old or
new userspace) Dell RBU to work with FW_LOADER_USER_HELPER_FALLBACK=n,
so maybe it would be best to test that instead.

Cheers,

Tom

2014-06-09 14:12:12

by B_B_Singh

[permalink] [raw]
Subject: RE: [PATCH] firmware loader: allow disabling of udev as firmware loader

Hi Tom,

Older userspace or existing DUP's doesn't work with your patch & CONFIG_FW_LOADER_USER_HELPER=n.

I will give a try with https://lkml.org/lkml/2014/6/4/327 new patch & let you know ASAP.

Regards
Balaji Singh


-----Original Message-----
From: Tom Gundersen [mailto:[email protected]]
Sent: Monday, June 09, 2014 7:23 PM
To: Singh, B B
Cc: LKML; Ming Lei; Greg KH; Abhay Salunke; Stefan Roese; Arnd Bergmann; Kay Sievers; Domsch, Matt; Gowda, Srinivas G; Hayes, Stuart
Subject: Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

Hi Balaji,

On Mon, Jun 9, 2014 at 3:26 PM, wrote:
> The existing BIOS-DUP's will not work on latest kernel, which has
> CONFIG_FW_LOADER_USER_HELPER=n configured in Kernel config by default
> which is not expected by the dell_rbu.
>
>
>
> We have made a changes in BIOS-Dell Update Package so that BIOS-DUP
> will pick the payload from the /lib/firmware/ path & update the BIOS
> even when CONFIG_FW_LOADER_USER_HELPER=n is configured .
>
>
>
> We have tested this patch
> http://www.spinics.net/lists/kernel/msg1755247.html with latest BIOS
> Dell Update Package (which has new implementation for the BIOS update
> i.e, copying the BIOS payload in /lib/firmware path & dell_rbu picks the payload
> from the same path) & with stable upstream kernel-3.14.5 & we don't
> see any negative effects/errors for dell_rbu.

Thanks for testing! May I ask if the dell_rbu still works with my patch and CONFIG_FW_LOADER_USER_HELPER=n with the old userspace? The intention was that you should not need to change anything in userspace at all.

By the way, there is now a new version of this patch:
, which should allow your (old or new userspace) Dell RBU to work with FW_LOADER_USER_HELPER_FALLBACK=n, so maybe it would be best to test that instead.

Cheers,

Tom

2014-06-09 15:51:04

by Tom Gundersen

[permalink] [raw]
Subject: Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

On Mon, Jun 9, 2014 at 4:01 PM, <[email protected]> wrote:
> Older userspace or existing DUP's doesn't work with your patch & CONFIG_FW_LOADER_USER_HELPER=n.
>
> I will give a try with https://lkml.org/lkml/2014/6/4/327 new patch & let you know ASAP.

Thanks!

Cheers,

Tom

2014-06-10 15:13:52

by B_B_Singh

[permalink] [raw]
Subject: RE: [PATCH] firmware loader: allow disabling of udev as firmware loader


Hi Tom,

I see contradiction of drivers/base/Kconfig here i.e, If I configure DELL_RBU=y I cannot configure FW_LOADER_USER_HELPER=n.
with this patch https://lkml.org/lkml/2014/6/4/327 i cannot have FW_LOADER_USER_HELPER=n & DELL_RBU=y at the same time.
I'm using the latest stable upstream kernel-3.14.5.

Symbol: FW_LOADER_USER_HELPER [=y]
Type : boolean
Defined at drivers/base/Kconfig:146
Selected by: FW_LOADER_USER_HELPER_FALLBACK [=n] && FW_LOADER [=y] || DELL_RBU [=y] && X86 [=y]

Regards
Balaji Singh


-----Original Message-----
From: Tom Gundersen [mailto:[email protected]]
Sent: Monday, June 09, 2014 9:21 PM
To: Singh, B B
Cc: LKML; Ming Lei; Greg KH; Abhay Salunke; Stefan Roese; Arnd Bergmann; Kay Sievers; Domsch, Matt; Gowda, Srinivas G; Hayes, Stuart
Subject: Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

On Mon, Jun 9, 2014 at 4:01 PM, wrote:
> Older userspace or existing DUP's doesn't work with your patch & CONFIG_FW_LOADER_USER_HELPER=n.
>
> I will give a try with https://lkml.org/lkml/2014/6/4/327 new patch & let you know ASAP.

Thanks!

Cheers,

Tom

2014-06-16 14:10:15

by B_B_Singh

[permalink] [raw]
Subject: RE: [PATCH] firmware loader: allow disabling of udev as firmware loader

Hi Tom,

Today I have tried with 3.15 the behavior is same as before.

Do you have any update on this?

Regards
Balaji Singh

-----Original Message-----
From: Singh, B B
Sent: Tuesday, June 10, 2014 8:44 PM
To: 'Tom Gundersen'
Cc: LKML; Ming Lei; Greg KH; Abhay Salunke; Stefan Roese; Arnd Bergmann; Kay Sievers; Domsch, Matt; Gowda, Srinivas G; Hayes, Stuart
Subject: RE: [PATCH] firmware loader: allow disabling of udev as firmware loader


Hi Tom,

I see contradiction of drivers/base/Kconfig here i.e, If I configure DELL_RBU=y I cannot configure FW_LOADER_USER_HELPER=n.
with this patch https://lkml.org/lkml/2014/6/4/327 i cannot have FW_LOADER_USER_HELPER=n & DELL_RBU=y at the same time.
I'm using the latest stable upstream kernel-3.14.5.

Symbol: FW_LOADER_USER_HELPER [=y]
Type : boolean
Defined at drivers/base/Kconfig:146
Selected by: FW_LOADER_USER_HELPER_FALLBACK [=n] && FW_LOADER [=y] || DELL_RBU [=y] && X86 [=y]

Regards
Balaji Singh


-----Original Message-----
From: Tom Gundersen [mailto:[email protected]]
Sent: Monday, June 09, 2014 9:21 PM
To: Singh, B B
Cc: LKML; Ming Lei; Greg KH; Abhay Salunke; Stefan Roese; Arnd Bergmann; Kay Sievers; Domsch, Matt; Gowda, Srinivas G; Hayes, Stuart
Subject: Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

On Mon, Jun 9, 2014 at 4:01 PM, wrote:
> Older userspace or existing DUP's doesn't work with your patch & CONFIG_FW_LOADER_USER_HELPER=n.
>
> I will give a try with https://lkml.org/lkml/2014/6/4/327 new patch & let you know ASAP.

Thanks!

Cheers,

Tom

2014-06-16 14:27:24

by Tom Gundersen

[permalink] [raw]
Subject: Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

On Tue, Jun 10, 2014 at 5:13 PM, <[email protected]> wrote:
> I see contradiction of drivers/base/Kconfig here i.e, If I configure DELL_RBU=y I cannot configure FW_LOADER_USER_HELPER=n.
> with this patch https://lkml.org/lkml/2014/6/4/327 i cannot have FW_LOADER_USER_HELPER=n & DELL_RBU=y at the same time.
> I'm using the latest stable upstream kernel-3.14.5.
>
> Symbol: FW_LOADER_USER_HELPER [=y]
> Type : boolean
> Defined at drivers/base/Kconfig:146
> Selected by: FW_LOADER_USER_HELPER_FALLBACK [=n] && FW_LOADER [=y] || DELL_RBU [=y] && X86 [=y]

Yes, with that version of the patch you should instead try with
FW_LOADER_USER_HELPER_FALLBACK=n (the options were renamed). Does that
work for you?

Cheers,

Tom

2014-06-16 14:28:29

by Tom Gundersen

[permalink] [raw]
Subject: Re: [PATCH] firmware loader: allow disabling of udev as firmware loader

On Mon, Jun 16, 2014 at 4:08 PM, <[email protected]> wrote:
> Today I have tried with 3.15 the behavior is same as before.

None of these patches were in 3.15, so that should behave as before.

Cheers,

Tom