From: Uwe Kleine-König <[email protected]>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/gpu/drm/bridge/chrontel-ch7033.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/chrontel-ch7033.c b/drivers/gpu/drm/bridge/chrontel-ch7033.c
index b94f39a86846..339b759e4c81 100644
--- a/drivers/gpu/drm/bridge/chrontel-ch7033.c
+++ b/drivers/gpu/drm/bridge/chrontel-ch7033.c
@@ -528,8 +528,7 @@ static const struct regmap_config ch7033_regmap_config = {
.max_register = 0x7f,
};
-static int ch7033_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int ch7033_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct ch7033_priv *priv;
@@ -604,7 +603,7 @@ static const struct i2c_device_id ch7033_ids[] = {
MODULE_DEVICE_TABLE(i2c, ch7033_ids);
static struct i2c_driver ch7033_driver = {
- .probe = ch7033_probe,
+ .probe_new = ch7033_probe,
.remove = ch7033_remove,
.driver = {
.name = "ch7033",
--
2.38.1
On Fri, Nov 18, 2022 at 11:35:53PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
> ---
> drivers/gpu/drm/bridge/chrontel-ch7033.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/chrontel-ch7033.c b/drivers/gpu/drm/bridge/chrontel-ch7033.c
> index b94f39a86846..339b759e4c81 100644
> --- a/drivers/gpu/drm/bridge/chrontel-ch7033.c
> +++ b/drivers/gpu/drm/bridge/chrontel-ch7033.c
> @@ -528,8 +528,7 @@ static const struct regmap_config ch7033_regmap_config = {
> .max_register = 0x7f,
> };
>
> -static int ch7033_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ch7033_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct ch7033_priv *priv;
> @@ -604,7 +603,7 @@ static const struct i2c_device_id ch7033_ids[] = {
> MODULE_DEVICE_TABLE(i2c, ch7033_ids);
>
> static struct i2c_driver ch7033_driver = {
> - .probe = ch7033_probe,
> + .probe_new = ch7033_probe,
> .remove = ch7033_remove,
> .driver = {
> .name = "ch7033",
--
Regards,
Laurent Pinchart
Hello dear drm/bridge maintainers,
On Fri, Nov 18, 2022 at 11:35:53PM +0100, Uwe Kleine-K?nig wrote:
> From: Uwe Kleine-K?nig <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
Do you plan to pick up the drm/bridge patches in the upcoming cycle?
You could do that using:
git pull https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/client_device_id_helper-immutable
b4 am -l -3 -P 14-35,37 [email protected]
git am -s ./20221118_uwe_i2c_complete_conversion_to_i2c_probe_new.mbx
Note that Doug Anderson already applied the patch for ti-sn65dsi86,
which is patch #36 and so this is skipped in the above range.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
On Wed, 7 Dec 2022 at 15:15, Uwe Kleine-König
<[email protected]> wrote:
>
> Hello dear drm/bridge maintainers,
>
> On Fri, Nov 18, 2022 at 11:35:53PM +0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <[email protected]>
> >
> > The probe function doesn't make use of the i2c_device_id * parameter so it
> > can be trivially converted.
> >
> > Signed-off-by: Uwe Kleine-König <[email protected]>
>
> Do you plan to pick up the drm/bridge patches in the upcoming cycle?
>
> You could do that using:
>
> git pull https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/client_device_id_helper-immutable
> b4 am -l -3 -P 14-35,37 [email protected]
> git am -s ./20221118_uwe_i2c_complete_conversion_to_i2c_probe_new.mbx
>
> Note that Doug Anderson already applied the patch for ti-sn65dsi86,
> which is patch #36 and so this is skipped in the above range.
Applied to drm-misc-next.
Feel free to grab a hold of me out of band if you hit any snags like this again.