There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/media/platform/qcom/camss/camss-ispif.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
index a30e453de162..37611c8861da 100644
--- a/drivers/media/platform/qcom/camss/camss-ispif.c
+++ b/drivers/media/platform/qcom/camss/camss-ispif.c
@@ -1145,17 +1145,13 @@ int msm_ispif_subdev_init(struct camss *camss,
r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
ispif->base = devm_ioremap_resource(dev, r);
- if (IS_ERR(ispif->base)) {
- dev_err(dev, "could not map memory\n");
+ if (IS_ERR(ispif->base))
return PTR_ERR(ispif->base);
- }
r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]);
ispif->base_clk_mux = devm_ioremap_resource(dev, r);
- if (IS_ERR(ispif->base_clk_mux)) {
- dev_err(dev, "could not map memory\n");
+ if (IS_ERR(ispif->base_clk_mux))
return PTR_ERR(ispif->base_clk_mux);
- }
/* Interrupt */
--
2.25.1
Hi Yang,
Thanks for the patch.
On Fri, 9 Apr 2021 at 07:03, Yang Yingliang <[email protected]> wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/media/platform/qcom/camss/camss-ispif.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
> index a30e453de162..37611c8861da 100644
> --- a/drivers/media/platform/qcom/camss/camss-ispif.c
> +++ b/drivers/media/platform/qcom/camss/camss-ispif.c
> @@ -1145,17 +1145,13 @@ int msm_ispif_subdev_init(struct camss *camss,
>
> r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
> ispif->base = devm_ioremap_resource(dev, r);
> - if (IS_ERR(ispif->base)) {
> - dev_err(dev, "could not map memory\n");
> + if (IS_ERR(ispif->base))
> return PTR_ERR(ispif->base);
> - }
>
> r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[1]);
> ispif->base_clk_mux = devm_ioremap_resource(dev, r);
> - if (IS_ERR(ispif->base_clk_mux)) {
> - dev_err(dev, "could not map memory\n");
> + if (IS_ERR(ispif->base_clk_mux))
> return PTR_ERR(ispif->base_clk_mux);
> - }
>
> /* Interrupt */
>
Reviewed-by: Robert Foss <[email protected]>