2021-05-04 22:30:48

by Adrien Grassein

Subject: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
DRM framework that needs VIDEOMODE_HELPERS to be enabled.

Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
Reported-by: Michal Suchánek <[email protected]>
Signed-off-by: Adrien Grassein <[email protected]>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 400193e38d29..70bcceaae9bf 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select REGMAP_I2C
+ select VIDEOMODE_HELPERS
help
Driver for Lontium LT8912B DSI to HDMI bridge
chip driver.
--
2.25.1

2021-05-05 14:32:28

by Robert Foss

Subject: Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

Pushed to drm-misc-next

On Wed, 5 May 2021 at 16:28, Robert Foss <[email protected]> wrote:
>
> Hi Adrien,
>
> Thanks for the quick fix.
>
> On Wed, 5 May 2021 at 00:02, Adrien Grassein <[email protected]> wrote:
> >
> > LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> > DRM framework that needs VIDEOMODE_HELPERS to be enabled.
> >
> > Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> > Reported-by: Michal Suchánek <[email protected]>
> > Signed-off-by: Adrien Grassein <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 400193e38d29..70bcceaae9bf 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
> > select DRM_KMS_HELPER
> > select DRM_MIPI_DSI
> > select REGMAP_I2C
> > + select VIDEOMODE_HELPERS
> > help
> > Driver for Lontium LT8912B DSI to HDMI bridge
> > chip driver.
> >
>
> Reviewed-by: Robert Foss <[email protected]>

2021-05-05 17:26:39

by Michal Suchánek

Subject: Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

On Wed, May 05, 2021 at 12:02:07AM +0200, Adrien Grassein wrote:
> LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> DRM framework that needs VIDEOMODE_HELPERS to be enabled.
>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Reported-by: Michal Such?nek <[email protected]>
> Signed-off-by: Adrien Grassein <[email protected]>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 400193e38d29..70bcceaae9bf 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select REGMAP_I2C
> + select VIDEOMODE_HELPERS
> help
> Driver for Lontium LT8912B DSI to HDMI bridge
> chip driver.

Indeed, this fixes the problem.

Thanks

Michal

2021-05-05 19:29:17

by Robert Foss

Subject: Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

Hi Adrien,

Thanks for the quick fix.

On Wed, 5 May 2021 at 00:02, Adrien Grassein <[email protected]> wrote:
>
> LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> DRM framework that needs VIDEOMODE_HELPERS to be enabled.
>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Reported-by: Michal Suchánek <[email protected]>
> Signed-off-by: Adrien Grassein <[email protected]>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 400193e38d29..70bcceaae9bf 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select REGMAP_I2C
> + select VIDEOMODE_HELPERS
> help
> Driver for Lontium LT8912B DSI to HDMI bridge
> chip driver.
>

Reviewed-by: Robert Foss <[email protected]>