2022-01-18 02:35:53

by Zhiming Liu

Subject: [PATCH v3] drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver

drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver.

We have got the device of i2c client in probe function.So we should remove extra
device acquisition method of i2c client.

Signed-off-by: Zhiming Liu <[email protected]>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++--
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index dafb1b47c15f..feb128a4557d 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
if (!lt9611)
return -ENOMEM;

- lt9611->dev = &client->dev;
+ lt9611->dev = dev;
lt9611->client = client;
lt9611->sleep = false;

@@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client,
return PTR_ERR(lt9611->regmap);
}

- ret = lt9611_parse_dt(&client->dev, lt9611);
+ ret = lt9611_parse_dt(dev, lt9611);
if (ret) {
dev_err(dev, "failed to parse device tree\n");
return ret;
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 33f9716da0ee..3d62e6bf6892 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
if (!lt9611uxc)
return -ENOMEM;

- lt9611uxc->dev = &client->dev;
+ lt9611uxc->dev = dev;
lt9611uxc->client = client;
mutex_init(&lt9611uxc->ocm_lock);

@@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
return PTR_ERR(lt9611uxc->regmap);
}

- ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc);
+ ret = lt9611uxc_parse_dt(dev, lt9611uxc);
if (ret) {
dev_err(dev, "failed to parse device tree\n");
return ret;
--
2.25.1

2022-01-18 02:36:05

by Robert Foss

Subject: Re: [PATCH v3] drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver

Hey Zhiming,

On Mon, 17 Jan 2022 at 16:42, Zhiming Liu <[email protected]> wrote:
>
> drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver.

The commit title is already in the email title, it doesn't need to be
sent twice, sorry if I was unclear about this.

>
> We have got the device of i2c client in probe function.So we should remove extra

This line is too long, and `checkpatch.pl --strict` complains about its length.

> device acquisition method of i2c client.
>
> Signed-off-by: Zhiming Liu <[email protected]>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++--
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index dafb1b47c15f..feb128a4557d 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
> if (!lt9611)
> return -ENOMEM;
>
> - lt9611->dev = &client->dev;
> + lt9611->dev = dev;
> lt9611->client = client;
> lt9611->sleep = false;
>
> @@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client,
> return PTR_ERR(lt9611->regmap);
> }
>
> - ret = lt9611_parse_dt(&client->dev, lt9611);
> + ret = lt9611_parse_dt(dev, lt9611);
> if (ret) {
> dev_err(dev, "failed to parse device tree\n");
> return ret;
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 33f9716da0ee..3d62e6bf6892 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
> if (!lt9611uxc)
> return -ENOMEM;
>
> - lt9611uxc->dev = &client->dev;
> + lt9611uxc->dev = dev;
> lt9611uxc->client = client;
> mutex_init(&lt9611uxc->ocm_lock);
>
> @@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
> return PTR_ERR(lt9611uxc->regmap);
> }
>
> - ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc);
> + ret = lt9611uxc_parse_dt(dev, lt9611uxc);
> if (ret) {
> dev_err(dev, "failed to parse device tree\n");
> return ret;
> --

I fixed the two remaining issues in your patch, but in the future I
would suggest running `checkpatch.pl --strict` on every patch before
emailing them out. It's very easy to miss something.

Reviewed-by: Robert Foss <[email protected]>

Applied to drm-misc-next.