2022-02-21 08:51:57

by José Expósito

[permalink] [raw]
Subject: [PATCH] drm/bridge: anx7625: switch to devm_drm_of_get_bridge

The function "drm_of_find_panel_or_bridge" has been deprecated in
favor of "devm_drm_of_get_bridge".

Switch to the new function and reduce boilerplate.

Signed-off-by: José Expósito <[email protected]>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 2346dbcc505f..dfeb800751d5 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1333,8 +1333,6 @@ static int anx7625_parse_dt(struct device *dev,
struct anx7625_platform_data *pdata)
{
struct device_node *np = dev->of_node, *ep0;
- struct drm_panel *panel;
- int ret;
int bus_type, mipi_lanes;

anx7625_get_swing_setting(dev, pdata);
@@ -1371,18 +1369,14 @@ static int anx7625_parse_dt(struct device *dev,
if (of_property_read_bool(np, "analogix,audio-enable"))
pdata->audio_en = 1;

- ret = drm_of_find_panel_or_bridge(np, 1, 0, &panel, NULL);
- if (ret < 0) {
- if (ret == -ENODEV)
+ pdata->panel_bridge = devm_drm_of_get_bridge(dev, np, 1, 0);
+ if (IS_ERR(pdata->panel_bridge)) {
+ if (PTR_ERR(pdata->panel_bridge) == -ENODEV)
return 0;
- return ret;
- }
- if (!panel)
- return -ENODEV;

- pdata->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
- if (IS_ERR(pdata->panel_bridge))
return PTR_ERR(pdata->panel_bridge);
+ }
+
DRM_DEV_DEBUG_DRIVER(dev, "get panel node.\n");

return 0;
--
2.25.1


2022-02-21 11:55:19

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge: anx7625: switch to devm_drm_of_get_bridge

On Mon, Feb 21, 2022 at 08:28:35AM +0100, Jos? Exp?sito wrote:
> The function "drm_of_find_panel_or_bridge" has been deprecated in
> favor of "devm_drm_of_get_bridge".
>
> Switch to the new function and reduce boilerplate.
>
> Signed-off-by: Jos? Exp?sito <[email protected]>

Reviewed-by: Maxime Ripard <[email protected]>

Maxime


Attachments:
(No filename) (353.00 B)
signature.asc (235.00 B)
Download all attachments

2022-03-09 16:13:51

by Robert Foss

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge: anx7625: switch to devm_drm_of_get_bridge

On Mon, 21 Feb 2022 at 09:55, Maxime Ripard <[email protected]> wrote:
>
> On Mon, Feb 21, 2022 at 08:28:35AM +0100, José Expósito wrote:
> > The function "drm_of_find_panel_or_bridge" has been deprecated in
> > favor of "devm_drm_of_get_bridge".
> >
> > Switch to the new function and reduce boilerplate.
> >
> > Signed-off-by: José Expósito <[email protected]>
>
> Reviewed-by: Maxime Ripard <[email protected]>

Applied to drm-misc-next