2021-10-02 23:37:42

by Dmitry Osipenko

Subject: [PATCH v1 1/5] drm/bridge: tc358768: Enable reference clock

The driver assumes that reference clock is always-enabled, but this is
hardware-dependent and not true for ASUS Transformer TF700T. Make driver
enable / disable the reference clock.

Tested-by: Andreas Westman Dorcsak <[email protected]> # Asus TF700T
Tested-by: Maxim Schwalm <[email protected]> #TF700T
Signed-off-by: Dmitry Osipenko <[email protected]>
---
drivers/gpu/drm/bridge/tc358768.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
index a3db532bbdd1..18ae6605a803 100644
--- a/drivers/gpu/drm/bridge/tc358768.c
+++ b/drivers/gpu/drm/bridge/tc358768.c
@@ -237,6 +237,10 @@ static void tc358768_hw_enable(struct tc358768_priv *priv)
if (priv->enabled)
return;

+ ret = clk_prepare_enable(priv->refclk);
+ if (ret < 0)
+ dev_err(priv->dev, "error enabling refclk (%d)\n", ret);
+
ret = regulator_bulk_enable(ARRAY_SIZE(priv->supplies), priv->supplies);
if (ret < 0)
dev_err(priv->dev, "error enabling regulators (%d)\n", ret);
@@ -274,6 +278,8 @@ static void tc358768_hw_disable(struct tc358768_priv *priv)
if (ret < 0)
dev_err(priv->dev, "error disabling regulators (%d)\n", ret);

+ clk_disable_unprepare(priv->refclk);
+
priv->enabled = false;
}

--
2.32.0

2021-10-19 08:49:02

by Robert Foss

Subject: Re: [PATCH v1 1/5] drm/bridge: tc358768: Enable reference clock

Hey Dmitry,

Thanks for submitting this series.

On Sun, 3 Oct 2021 at 01:35, Dmitry Osipenko <[email protected]> wrote:
>
> The driver assumes that reference clock is always-enabled, but this is
> hardware-dependent and not true for ASUS Transformer TF700T. Make driver
> enable / disable the reference clock.
>
> Tested-by: Andreas Westman Dorcsak <[email protected]> # Asus TF700T
> Tested-by: Maxim Schwalm <[email protected]> #TF700T
> Signed-off-by: Dmitry Osipenko <[email protected]>
> ---
> drivers/gpu/drm/bridge/tc358768.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
> index a3db532bbdd1..18ae6605a803 100644
> --- a/drivers/gpu/drm/bridge/tc358768.c
> +++ b/drivers/gpu/drm/bridge/tc358768.c
> @@ -237,6 +237,10 @@ static void tc358768_hw_enable(struct tc358768_priv *priv)
> if (priv->enabled)
> return;
>
> + ret = clk_prepare_enable(priv->refclk);
> + if (ret < 0)
> + dev_err(priv->dev, "error enabling refclk (%d)\n", ret);
> +
> ret = regulator_bulk_enable(ARRAY_SIZE(priv->supplies), priv->supplies);
> if (ret < 0)
> dev_err(priv->dev, "error enabling regulators (%d)\n", ret);
> @@ -274,6 +278,8 @@ static void tc358768_hw_disable(struct tc358768_priv *priv)
> if (ret < 0)
> dev_err(priv->dev, "error disabling regulators (%d)\n", ret);
>
> + clk_disable_unprepare(priv->refclk);
> +
> priv->enabled = false;
> }
>

Reviewed-by: Robert Foss <[email protected]>