2022-01-11 03:41:11

by Zhiming Liu

Subject: [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver

Signed-off-by: lzmlzm <[email protected]>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +-
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index dafb1b47c15f..e0feb4fd9780 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
if (!lt9611)
return -ENOMEM;

- lt9611->dev = &client->dev;
+ lt9611->dev = dev;
lt9611->client = client;
lt9611->sleep = false;

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 33f9716da0ee..e50e42312e82 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
if (!lt9611uxc)
return -ENOMEM;

- lt9611uxc->dev = &client->dev;
+ lt9611uxc->dev = dev;
lt9611uxc->client = client;
mutex_init(&lt9611uxc->ocm_lock);

--
2.25.1

2022-01-13 10:14:38

by Robert Foss

Subject: Re: [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver

Hello,

Thanks for submitting this cleanup patch.

On Tue, 11 Jan 2022 at 04:41, lzmlzm <[email protected]> wrote:
>

A commit message is necessary for all changes, no matter how trivial.

> Signed-off-by: lzmlzm <[email protected]>

Is your name listed correctly above? For the 'Signed-off-by' tag to be
meaningful, a real name needs to be supplied.

> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +-
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index dafb1b47c15f..e0feb4fd9780 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
> if (!lt9611)
> return -ENOMEM;
>
> - lt9611->dev = &client->dev;
> + lt9611->dev = dev;
> lt9611->client = client;
> lt9611->sleep = false;
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 33f9716da0ee..e50e42312e82 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
> if (!lt9611uxc)
> return -ENOMEM;
>
> - lt9611uxc->dev = &client->dev;
> + lt9611uxc->dev = dev;
> lt9611uxc->client = client;
> mutex_init(&lt9611uxc->ocm_lock);
>
> --

With these two issues fixed, please submit a v2 of this patch.


Rob.