The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
on EXTCON, which causes issues when sii8620 is built
as a builtin and EXTCON is built as a module.
The symptoms are 'undefined reference' errors caused
by the symbols in EXTCON not being available
to the sii8620 driver.
Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
Signed-off-by: Robert Foss <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
LKP reported issue:
https://lore.kernel.org/lkml/[email protected]/
Changes since v1:
- Fix typo on comment
Changes since v2:
- Randy: Changed from `depends` to `select`
drivers/gpu/drm/bridge/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 22a467abd3e9..70402da5cc70 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -169,7 +169,7 @@ config DRM_SIL_SII8620
tristate "Silicon Image SII8620 HDMI/MHL bridge"
depends on OF
select DRM_KMS_HELPER
- imply EXTCON
+ select EXTCON
depends on RC_CORE || !RC_CORE
help
Silicon Image SII8620 HDMI/MHL bridge chip driver.
--
2.31.0.30.g398dba342d.dirty
On 4/19/21 2:01 AM, Robert Foss wrote:
> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
> on EXTCON, which causes issues when sii8620 is built
> as a builtin and EXTCON is built as a module.
>
> The symptoms are 'undefined reference' errors caused
> by the symbols in EXTCON not being available
> to the sii8620 driver.
>
> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
> Signed-off-by: Robert Foss <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> ---
>
> LKP reported issue:
> https://lore.kernel.org/lkml/[email protected]/
>
>
> Changes since v1:
> - Fix typo on comment
>
> Changes since v2:
> - Randy: Changed from `depends` to `select`
I don't know why my name is on that. I didn't
suggest any change -- I just reported that v2
had a problem.
>
>
> drivers/gpu/drm/bridge/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 22a467abd3e9..70402da5cc70 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620
> tristate "Silicon Image SII8620 HDMI/MHL bridge"
> depends on OF
> select DRM_KMS_HELPER
> - imply EXTCON
> + select EXTCON
> depends on RC_CORE || !RC_CORE
> help
> Silicon Image SII8620 HDMI/MHL bridge chip driver.
Thanks. Works For Me.
Acked-by: Randy Dunlap <[email protected]> # build-tested
--
~Randy
On 4/19/21 10:10 AM, Randy Dunlap wrote:
> On 4/19/21 2:01 AM, Robert Foss wrote:
>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
>> on EXTCON, which causes issues when sii8620 is built
>> as a builtin and EXTCON is built as a module.
>>
>> The symptoms are 'undefined reference' errors caused
>> by the symbols in EXTCON not being available
>> to the sii8620 driver.
>>
>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
>> Signed-off-by: Robert Foss <[email protected]>
>> Reported-by: kernel test robot <[email protected]>
>> ---
>>
>> LKP reported issue:
>> https://lore.kernel.org/lkml/[email protected]/
>>
>>
>> Changes since v1:
>> - Fix typo on comment
>>
>> Changes since v2:
>> - Randy: Changed from `depends` to `select`
>
> I don't know why my name is on that. I didn't
> suggest any change -- I just reported that v2
> had a problem.
>
>
>>
>>
>> drivers/gpu/drm/bridge/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>> index 22a467abd3e9..70402da5cc70 100644
>> --- a/drivers/gpu/drm/bridge/Kconfig
>> +++ b/drivers/gpu/drm/bridge/Kconfig
>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620
>> tristate "Silicon Image SII8620 HDMI/MHL bridge"
>> depends on OF
>> select DRM_KMS_HELPER
>> - imply EXTCON
>> + select EXTCON
>> depends on RC_CORE || !RC_CORE
>> help
>> Silicon Image SII8620 HDMI/MHL bridge chip driver.
>
>
> Thanks. Works For Me.
>
> Acked-by: Randy Dunlap <[email protected]> # build-tested
Actually I can upgrade that to:
Reviewed-by: Randy Dunlap <[email protected]>
ta.
--
~Randy
On 4/19/21 10:54 AM, Randy Dunlap wrote:
> On 4/19/21 10:10 AM, Randy Dunlap wrote:
>> On 4/19/21 2:01 AM, Robert Foss wrote:
>>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
>>> on EXTCON, which causes issues when sii8620 is built
>>> as a builtin and EXTCON is built as a module.
>>>
>>> The symptoms are 'undefined reference' errors caused
>>> by the symbols in EXTCON not being available
>>> to the sii8620 driver.
>>>
>>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
>>> Signed-off-by: Robert Foss <[email protected]>
>>> Reported-by: kernel test robot <[email protected]>
>>> ---
>>>
>>> LKP reported issue:
>>> https://lore.kernel.org/lkml/[email protected]/
>>>
>>>
>>> Changes since v1:
>>> - Fix typo on comment
>>>
>>> Changes since v2:
>>> - Randy: Changed from `depends` to `select`
>>
>> I don't know why my name is on that. I didn't
>> suggest any change -- I just reported that v2
>> had a problem.
>>
>>
>>>
>>>
>>> drivers/gpu/drm/bridge/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>>> index 22a467abd3e9..70402da5cc70 100644
>>> --- a/drivers/gpu/drm/bridge/Kconfig
>>> +++ b/drivers/gpu/drm/bridge/Kconfig
>>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620
>>> tristate "Silicon Image SII8620 HDMI/MHL bridge"
>>> depends on OF
>>> select DRM_KMS_HELPER
>>> - imply EXTCON
>>> + select EXTCON
>>> depends on RC_CORE || !RC_CORE
>>> help
>>> Silicon Image SII8620 HDMI/MHL bridge chip driver.
>>
>>
>> Thanks. Works For Me.
>>
>> Acked-by: Randy Dunlap <[email protected]> # build-tested
>
> Actually I can upgrade that to:
>
> Reviewed-by: Randy Dunlap <[email protected]>
Hi,
Is anyone merging this patch?
thanks.
--
~Randy
Hey Randy,
I missed sending out a notification, but this patch was merged into
drm-misc-next.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=08319adbdde15ef7cee1970336f63461254baa2a
On Sat, 15 May 2021 at 07:35, Randy Dunlap <[email protected]> wrote:
>
> On 4/19/21 10:54 AM, Randy Dunlap wrote:
> > On 4/19/21 10:10 AM, Randy Dunlap wrote:
> >> On 4/19/21 2:01 AM, Robert Foss wrote:
> >>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
> >>> on EXTCON, which causes issues when sii8620 is built
> >>> as a builtin and EXTCON is built as a module.
> >>>
> >>> The symptoms are 'undefined reference' errors caused
> >>> by the symbols in EXTCON not being available
> >>> to the sii8620 driver.
> >>>
> >>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
> >>> Signed-off-by: Robert Foss <[email protected]>
> >>> Reported-by: kernel test robot <[email protected]>
> >>> ---
> >>>
> >>> LKP reported issue:
> >>> https://lore.kernel.org/lkml/[email protected]/
> >>>
> >>>
> >>> Changes since v1:
> >>> - Fix typo on comment
> >>>
> >>> Changes since v2:
> >>> - Randy: Changed from `depends` to `select`
> >>
> >> I don't know why my name is on that. I didn't
> >> suggest any change -- I just reported that v2
> >> had a problem.
> >>
> >>
> >>>
> >>>
> >>> drivers/gpu/drm/bridge/Kconfig | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> >>> index 22a467abd3e9..70402da5cc70 100644
> >>> --- a/drivers/gpu/drm/bridge/Kconfig
> >>> +++ b/drivers/gpu/drm/bridge/Kconfig
> >>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620
> >>> tristate "Silicon Image SII8620 HDMI/MHL bridge"
> >>> depends on OF
> >>> select DRM_KMS_HELPER
> >>> - imply EXTCON
> >>> + select EXTCON
> >>> depends on RC_CORE || !RC_CORE
> >>> help
> >>> Silicon Image SII8620 HDMI/MHL bridge chip driver.
> >>
> >>
> >> Thanks. Works For Me.
> >>
> >> Acked-by: Randy Dunlap <[email protected]> # build-tested
> >
> > Actually I can upgrade that to:
> >
> > Reviewed-by: Randy Dunlap <[email protected]>
>
> Hi,
> Is anyone merging this patch?
>
> thanks.
> --
> ~Randy
>
On 5/15/21 5:09 AM, Robert Foss wrote:
> Hey Randy,
>
> I missed sending out a notification, but this patch was merged into
> drm-misc-next.
>
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=08319adbdde15ef7cee1970336f63461254baa2a
OK, thanks, Robert.
I was mainly asking because the 0day bot sent out a build failure
that this patch fixes, but it was dated 2021-MAY-05, so I guess I can
just ignore it, since it is so old. :)
> On Sat, 15 May 2021 at 07:35, Randy Dunlap <[email protected]> wrote:
>>
>> On 4/19/21 10:54 AM, Randy Dunlap wrote:
>>> On 4/19/21 10:10 AM, Randy Dunlap wrote:
>>>> On 4/19/21 2:01 AM, Robert Foss wrote:
>>>>> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
>>>>> on EXTCON, which causes issues when sii8620 is built
>>>>> as a builtin and EXTCON is built as a module.
>>>>>
>>>>> The symptoms are 'undefined reference' errors caused
>>>>> by the symbols in EXTCON not being available
>>>>> to the sii8620 driver.
>>>>>
>>>>> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
>>>>> Signed-off-by: Robert Foss <[email protected]>
>>>>> Reported-by: kernel test robot <[email protected]>
>>>>> ---
>>>>>
>>>>> LKP reported issue:
>>>>> https://lore.kernel.org/lkml/[email protected]/
>>>>>
>>>>>
>>>>> Changes since v1:
>>>>> - Fix typo on comment
>>>>>
>>>>> Changes since v2:
>>>>> - Randy: Changed from `depends` to `select`
>>>>
>>>> I don't know why my name is on that. I didn't
>>>> suggest any change -- I just reported that v2
>>>> had a problem.
>>>>
>>>>
>>>>>
>>>>>
>>>>> drivers/gpu/drm/bridge/Kconfig | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>>>>> index 22a467abd3e9..70402da5cc70 100644
>>>>> --- a/drivers/gpu/drm/bridge/Kconfig
>>>>> +++ b/drivers/gpu/drm/bridge/Kconfig
>>>>> @@ -169,7 +169,7 @@ config DRM_SIL_SII8620
>>>>> tristate "Silicon Image SII8620 HDMI/MHL bridge"
>>>>> depends on OF
>>>>> select DRM_KMS_HELPER
>>>>> - imply EXTCON
>>>>> + select EXTCON
>>>>> depends on RC_CORE || !RC_CORE
>>>>> help
>>>>> Silicon Image SII8620 HDMI/MHL bridge chip driver.
>>>>
>>>>
>>>> Thanks. Works For Me.
>>>>
>>>> Acked-by: Randy Dunlap <[email protected]> # build-tested
>>>
>>> Actually I can upgrade that to:
>>>
>>> Reviewed-by: Randy Dunlap <[email protected]>
>>
>> Hi,
>> Is anyone merging this patch?
>>
>> thanks.
>> --
--
~Randy