2021-01-11 12:03:19

by Robert Foss

Subject: [PATCH v2] media: ov8856: Configure sensor for GRBG Bayer for all modes

The previously added modes 3264x2448 & 1632x1224 are actually
configuring the sensor for BGGR mode, this is an issue since
the mode that is exposed through V4L incorrectly is set as GRBG.

This patch fixes the issue by configuring the sensor to always
output GRBG Bayer formatted frames.

Signed-off-by: Robert Foss <[email protected]>
Suggested-by: Andrey Konovalov <[email protected]>
---


Changes since v1:
- Sakari: Added mode information to ov8856_mode struct
- Sakari: enum_mbus_code updated

Changes since v2:
- Andrey: Switched approach to changing the sensor configuration
to yield identical Bayer modes for all modes


drivers/media/i2c/ov8856.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
index 2f4ceaa80593..8a355135c7db 100644
--- a/drivers/media/i2c/ov8856.c
+++ b/drivers/media/i2c/ov8856.c
@@ -428,7 +428,7 @@ static const struct ov8856_reg mode_3264x2448_regs[] = {
{0x3810, 0x00},
{0x3811, 0x04},
{0x3812, 0x00},
- {0x3813, 0x02},
+ {0x3813, 0x01},
{0x3814, 0x01},
{0x3815, 0x01},
{0x3816, 0x00},
@@ -821,7 +821,7 @@ static const struct ov8856_reg mode_1632x1224_regs[] = {
{0x3810, 0x00},
{0x3811, 0x02},
{0x3812, 0x00},
- {0x3813, 0x02},
+ {0x3813, 0x01},
{0x3814, 0x03},
{0x3815, 0x01},
{0x3816, 0x00},
--
2.27.0

2021-01-11 12:06:13

by Robert Foss

Subject: Re: [PATCH v2] media: ov8856: Configure sensor for GRBG Bayer for all modes

Darn, this should have been sent out as v3.

On Mon, 11 Jan 2021 at 13:00, Robert Foss <[email protected]> wrote:
>
> The previously added modes 3264x2448 & 1632x1224 are actually
> configuring the sensor for BGGR mode, this is an issue since
> the mode that is exposed through V4L incorrectly is set as GRBG.
>
> This patch fixes the issue by configuring the sensor to always
> output GRBG Bayer formatted frames.
>
> Signed-off-by: Robert Foss <[email protected]>
> Suggested-by: Andrey Konovalov <[email protected]>
> ---
>
>
> Changes since v1:
> - Sakari: Added mode information to ov8856_mode struct
> - Sakari: enum_mbus_code updated
>
> Changes since v2:
> - Andrey: Switched approach to changing the sensor configuration
> to yield identical Bayer modes for all modes
>
>
> drivers/media/i2c/ov8856.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
> index 2f4ceaa80593..8a355135c7db 100644
> --- a/drivers/media/i2c/ov8856.c
> +++ b/drivers/media/i2c/ov8856.c
> @@ -428,7 +428,7 @@ static const struct ov8856_reg mode_3264x2448_regs[] = {
> {0x3810, 0x00},
> {0x3811, 0x04},
> {0x3812, 0x00},
> - {0x3813, 0x02},
> + {0x3813, 0x01},
> {0x3814, 0x01},
> {0x3815, 0x01},
> {0x3816, 0x00},
> @@ -821,7 +821,7 @@ static const struct ov8856_reg mode_1632x1224_regs[] = {
> {0x3810, 0x00},
> {0x3811, 0x02},
> {0x3812, 0x00},
> - {0x3813, 0x02},
> + {0x3813, 0x01},
> {0x3814, 0x03},
> {0x3815, 0x01},
> {0x3816, 0x00},
> --
> 2.27.0
>