2014-04-30 03:59:12

by Jidong Xiao

[permalink] [raw]
Subject: Re: Is heap_stack_gap useless?

Resend to kernel-development list.

The original email wasn't plaintext mode and was rejected by
kernel-development list.

On Tue, Apr 29, 2014 at 11:31 PM, Jidong Xiao <[email protected]> wrote:
> Hi,
>
> I noticed this variable, defined in mm/nommu.c,
>
> mm/nommu.c:int heap_stack_gap = 0;
>
> This variable only shows up once, and never shows up in elsewhere.
>
> Can some one tell me is this useless? If so, I will submit a patch to remove
> it.
>
> -Jidong


2014-04-30 08:36:24

by Michal Hocko

[permalink] [raw]
Subject: Re: Is heap_stack_gap useless?

On Tue 29-04-14 23:59:09, Jidong Xiao wrote:
> On Tue, Apr 29, 2014 at 11:31 PM, Jidong Xiao <[email protected]> wrote:
> > Hi,
> >
> > I noticed this variable, defined in mm/nommu.c,
> >
> > mm/nommu.c:int heap_stack_gap = 0;
> >
> > This variable only shows up once, and never shows up in elsewhere.
> >
> > Can some one tell me is this useless? If so, I will submit a patch to remove
> > it.

Hint: Do not be afraid to do a bit of git research when you want to do
clean-ups like this.
--
Michal Hocko
SUSE Labs