2013-04-14 21:25:07

by Alexandru Gheorghiu

Subject: [PATCH] lib: digsig: Use ERR_CAST function

Use ERR_CAST function instead of ERR_PTR and PTR_ERR.
Patch found using coccinelle.

Signed-off-by: Alexandru Gheorghiu <[email protected]>
---
lib/digsig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/digsig.c b/lib/digsig.c
index 2f31e6a..8793aed 100644
--- a/lib/digsig.c
+++ b/lib/digsig.c
@@ -209,7 +209,7 @@ int digsig_verify(struct key *keyring, const char *sig, int siglen,
kref = keyring_search(make_key_ref(keyring, 1UL),
&key_type_user, name);
if (IS_ERR(kref))
- key = ERR_PTR(PTR_ERR(kref));
+ key = ERR_CAST(kref);
else
key = key_ref_to_ptr(kref);
} else {
--
1.7.9.5

2013-05-31 14:41:55

by Dmitry Kasatkin

Subject: Re: [PATCH] lib: digsig: Use ERR_CAST function

Sorry. I am not at @intel.com any more. Did not see it.
I will use my private email for now..

Yes. This was bothering my eye for quite a while...

- Dmitry

On Fri, Apr 12, 2013 at 4:12 AM, Alexandru Gheorghiu
<[email protected]> wrote:
>
> Use ERR_CAST function instead of ERR_PTR and PTR_ERR.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu <[email protected]>
> ---
> lib/digsig.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/digsig.c b/lib/digsig.c
> index 2f31e6a..8793aed 100644
> --- a/lib/digsig.c
> +++ b/lib/digsig.c
> @@ -209,7 +209,7 @@ int digsig_verify(struct key *keyring, const char
> *sig, int siglen,
> kref = keyring_search(make_key_ref(keyring, 1UL),
> &key_type_user, name);
> if (IS_ERR(kref))
> - key = ERR_PTR(PTR_ERR(kref));
> + key = ERR_CAST(kref);
> else
> key = key_ref_to_ptr(kref);
> } else {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/