2017-04-24 09:27:01

by Colin King

Subject: [PATCH][V2] IB/rxe: fix typo: "algorithmi" -> "algorithm"

From: Colin Ian King <[email protected]>

trivial fix to typo in pr_err message

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index 486035a85bac..6a4b02470d21 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -1324,7 +1324,7 @@ int rxe_register_device(struct rxe_dev *rxe)

rxe->tfm = crypto_alloc_shash("crc32", 0, 0);
if (IS_ERR(rxe->tfm)) {
- pr_err("failed to allocate crc algorithmi err:%ld",
+ pr_err("failed to allocate crc algorithm err:%ld",
PTR_ERR(rxe->tfm));
return PTR_ERR(rxe->tfm);
}
--
2.11.0

2017-04-24 09:41:32

by Moni Shoua

Subject: Re: [PATCH][V2] IB/rxe: fix typo: "algorithmi" -> "algorithm"

On Mon, Apr 24, 2017 at 12:26 PM, Colin King <[email protected]> wrote:
> From: Colin Ian King <[email protected]>
>
> trivial fix to typo in pr_err message
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index 486035a85bac..6a4b02470d21 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -1324,7 +1324,7 @@ int rxe_register_device(struct rxe_dev *rxe)
>
> rxe->tfm = crypto_alloc_shash("crc32", 0, 0);
> if (IS_ERR(rxe->tfm)) {
> - pr_err("failed to allocate crc algorithmi err:%ld",
> + pr_err("failed to allocate crc algorithm err:%ld",
> PTR_ERR(rxe->tfm));
> return PTR_ERR(rxe->tfm);
> }
> --
> 2.11.0

Thanks (for both patches)

2017-04-24 17:45:18

by Joe Perches

Subject: Re: [PATCH][V2] IB/rxe: fix typo: "algorithmi" -> "algorithm"

On Mon, 2017-04-24 at 10:26 +0100, Colin King wrote:
> trivial fix to typo in pr_err message
[]
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
[]
> @@ -1324,7 +1324,7 @@ int rxe_register_device(struct rxe_dev *rxe)
>
> rxe->tfm = crypto_alloc_shash("crc32", 0, 0);
> if (IS_ERR(rxe->tfm)) {
> - pr_err("failed to allocate crc algorithmi err:%ld",
> + pr_err("failed to allocate crc algorithm err:%ld",

nicer to add a newline too

2017-04-28 17:08:39

by Doug Ledford

Subject: Re: [PATCH][V2] IB/rxe: fix typo: "algorithmi" -> "algorithm"

On Mon, 2017-04-24 at 10:44 -0700, Joe Perches wrote:
> On Mon, 2017-04-24 at 10:26 +0100, Colin King wrote:
> >
> > trivial fix to typo in pr_err message
> []
> >
> > diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c
> > b/drivers/infiniband/sw/rxe/rxe_verbs.c
> []
> >
> > @@ -1324,7 +1324,7 @@ int rxe_register_device(struct rxe_dev *rxe)
> >  
> >   rxe->tfm = crypto_alloc_shash("crc32", 0, 0);
> >   if (IS_ERR(rxe->tfm)) {
> > - pr_err("failed to allocate crc algorithmi
> > err:%ld",
> > + pr_err("failed to allocate crc algorithm err:%ld",
>
> nicer to add a newline too

I added a newline and then applied the patch.  Thanks.

--
Doug Ledford <[email protected]>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

2017-04-28 17:15:06

by Colin King

Subject: Re: [PATCH][V2] IB/rxe: fix typo: "algorithmi" -> "algorithm"

On 28/04/17 18:08, Doug Ledford wrote:
> On Mon, 2017-04-24 at 10:44 -0700, Joe Perches wrote:
>> On Mon, 2017-04-24 at 10:26 +0100, Colin King wrote:
>>>
>>> trivial fix to typo in pr_err message
>> []
>>>
>>> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c
>>> b/drivers/infiniband/sw/rxe/rxe_verbs.c
>> []
>>>
>>> @@ -1324,7 +1324,7 @@ int rxe_register_device(struct rxe_dev *rxe)
>>>
>>> rxe->tfm = crypto_alloc_shash("crc32", 0, 0);
>>> if (IS_ERR(rxe->tfm)) {
>>> - pr_err("failed to allocate crc algorithmi
>>> err:%ld",
>>> + pr_err("failed to allocate crc algorithm err:%ld",
>>
>> nicer to add a newline too
>
> I added a newline and then applied the patch. Thanks.
>
Thanks Doug. I overlooked replying to the earlier email.

Colin