2013-03-06 09:52:40

by Paul Bolle

Subject: [PATCH] ARM: mach-bcm: drop "select GENERIC_TIME"

The Kconfig symbol GENERIC_TIME was removed from the kernel in v2.6.36,
with commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b ("time: Kill off
CONFIG_GENERIC_TIME"). Somehow this select statement still popped up
recently. It's a nop so we can drop it.

Signed-off-by: Paul Bolle <[email protected]>
---
Tested with "git grep" only.

arch/arm/mach-bcm/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index bf02471..be4a0a1 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -7,7 +7,6 @@ config ARCH_BCM
select ARM_GIC
select CPU_V7
select GENERIC_CLOCKEVENTS
- select GENERIC_TIME
select GPIO_BCM
select SPARSE_IRQ
select TICK_ONESHOT
--
1.7.11.7

2013-03-08 03:18:33

by Christian Daudt

Subject: Re: [PATCH] ARM: mach-bcm: drop "select GENERIC_TIME"

My bad. Thanks for the fix !

Reviewed-by: Christian Daudt <[email protected]>


Thanks,
csd


On Wed, Mar 6, 2013 at 1:52 AM, Paul Bolle <[email protected]> wrote:
> The Kconfig symbol GENERIC_TIME was removed from the kernel in v2.6.36,
> with commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b ("time: Kill off
> CONFIG_GENERIC_TIME"). Somehow this select statement still popped up
> recently. It's a nop so we can drop it.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> Tested with "git grep" only.
>
> arch/arm/mach-bcm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index bf02471..be4a0a1 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -7,7 +7,6 @@ config ARCH_BCM
> select ARM_GIC
> select CPU_V7
> select GENERIC_CLOCKEVENTS
> - select GENERIC_TIME
> select GPIO_BCM
> select SPARSE_IRQ
> select TICK_ONESHOT
> --
> 1.7.11.7
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2013-03-08 12:39:56

by Paul Bolle

Subject: Re: [PATCH] ARM: mach-bcm: drop "select GENERIC_TIME"

On Thu, 2013-03-07 at 19:18 -0800, Christian Daudt wrote:
> My bad. Thanks for the fix !
>
> Reviewed-by: Christian Daudt <[email protected]>

In the same commit, 8ac49e0485bb79223a111b366a3b1f5ec9148729 ("Add
support for generic BCM SoC chipsets"), you also added
select GPIO_BCM

There's currently no Kconfig symbol by that name. Is it perhaps needed
for future enhancements?


Paul Bolle